fix(trainer): add missing wildcard to .pt and .pth ignore patterns#372
fix(trainer): add missing wildcard to .pt and .pth ignore patterns#372ghazariann wants to merge 2 commits intokubeflow:mainfrom
Conversation
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where INITIALIZER_DEFAULT_IGNORE_PATTERNS in constants.py had .pt and .pth entries missing the * glob wildcard prefix, meaning files like model.pt or weights.pth were never matched by the ignore patterns during model initialization.
Changes:
- Added
*wildcard prefix to.ptand.pthpatterns, changing them to*.ptand*.pthto match the existing convention used by the other entries (*.msgpack,*.h5,*.bin).
You can also share your feedback on Copilot code review. Take the survey.
kramaranya
left a comment
There was a problem hiding this comment.
Thanks @ghazariann!
/lgtm
andreyvelich
left a comment
There was a problem hiding this comment.
Thanks @ghazariann!
This needs to be aligned with Trainer initializer: https://github.com/kubeflow/trainer/blob/db1047909da21407f89b99969b2e2c7cc484d69e/pkg/initializers/types/types.py#L31-L41
Can you update it as well please?
/ok-to-test
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Vahagn <vghazaryan@cloudlinux.com>
Signed-off-by: ghazariann <vahagn.ghazayan@gmail.com>
Done! Fixed in kubeflow/trainer#3307 |
What this PR does / why we need it:
Fixes a typo in
INITIALIZER_DEFAULT_IGNORE_PATTERNS—.ptand.pthwere missing the*wildcard prefix, so files likemodel.ptorweights.pthwere never actually ignored during model initialization.Which issue(s) this PR fixes:
Fixes #370
Checklist: