Skip to content

fix(trainer): add missing wildcard to .pt and .pth ignore patterns #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghazariann wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix(trainer): add missing wildcard to .pt and .pth ignore patterns #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
283e3f3
fix(trainer): add missing wildcard to .pt and .pth ignore patterns
Mar 8, 2026
50800c7
docs(trainer): fix wildcard patterns in S3ModelInitializer docstring
ghazariann Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kubeflow/trainer/constants/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
INITIALIZER_ENV_ACCESS_TOKEN = "ACCESS_TOKEN"

# The default value for initializer to ignore files.
INITIALIZER_DEFAULT_IGNORE_PATTERNS = ["*.msgpack", "*.h5", "*.bin", ".pt", ".pth"]
INITIALIZER_DEFAULT_IGNORE_PATTERNS = ["*.msgpack", "*.h5", "*.bin", "*.pt", "*.pth"]

# The default path to the users' workspace.
# TODO (andreyvelich): Discuss how to keep this path is sync with pkg.initializers.constants
Expand Down
2 changes: 1 addition & 1 deletion kubeflow/trainer/types/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ class S3ModelInitializer(BaseInitializer):
Args:
storage_uri (`str`): The S3 URI for the model in the format 's3://bucket-name/path/to/model'.
ignore_patterns (`Optional[list[str]]`): List of file patterns to ignore during download.
Defaults to `['*.msgpack', '*.h5', '*.bin', '.pt', '.pth']`.
Defaults to `['*.msgpack', '*.h5', '*.bin', '*.pt', '*.pth']`.
endpoint (`Optional[str]`): Custom S3 endpoint URL.
access_key_id (`Optional[str]`): Access key for authentication.
secret_access_key (`Optional[str]`): Secret key for authentication.
Expand Down
Loading