Skip to content

feat: add-storageuri-targetjob-validation#3303

Open
pulkit-999 wants to merge 2 commits intokubeflow:masterfrom
pulkit-999:feat/add-storageuri-targetjob-validation
Open

feat: add-storageuri-targetjob-validation#3303
pulkit-999 wants to merge 2 commits intokubeflow:masterfrom
pulkit-999:feat/add-storageuri-targetjob-validation

Conversation

@pulkit-999
Copy link

  • Add regex pattern validation for StorageUri fields in DatasetInitializer
  • Add name format validation for PodTemplateOverrideTargetJob.Name to match Kubernetes naming conventions

Copilot AI review requested due to automatic review settings March 10, 2026 14:11
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign electronic-waste for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
  • Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens API-level validation on the trainer.kubeflow.org/v1alpha1 TrainJob types by adding regex constraints for dataset storageUri values and for PodTemplateOverrideTargetJob.Name to better align with Kubernetes-style naming.

Changes:

  • Add a kubebuilder Pattern validation for DatasetInitializer.StorageUri to restrict values to either scheme://... or absolute paths.
  • Add a kubebuilder Pattern validation for PodTemplateOverrideTargetJob.Name to enforce DNS-1123 label-like formatting.

@pulkit-999 pulkit-999 changed the title add URI format and target job name validation feat: add-storageuri-targetjob-validation Mar 10, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants