feat: add-storageuri-targetjob-validation#3303
feat: add-storageuri-targetjob-validation#3303pulkit-999 wants to merge 2 commits intokubeflow:masterfrom
Conversation
pulkit-999
commented
Mar 10, 2026
- Add regex pattern validation for StorageUri fields in DatasetInitializer
- Add name format validation for PodTemplateOverrideTargetJob.Name to match Kubernetes naming conventions
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
There was a problem hiding this comment.
Pull request overview
This PR tightens API-level validation on the trainer.kubeflow.org/v1alpha1 TrainJob types by adding regex constraints for dataset storageUri values and for PodTemplateOverrideTargetJob.Name to better align with Kubernetes-style naming.
Changes:
- Add a kubebuilder
Patternvalidation forDatasetInitializer.StorageUrito restrict values to eitherscheme://...or absolute paths. - Add a kubebuilder
Patternvalidation forPodTemplateOverrideTargetJob.Nameto enforce DNS-1123 label-like formatting.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>