Skip to content

feat: add-storageuri-targetjob-validation #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pulkit-999 wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −0
Open

feat: add-storageuri-targetjob-validation #3303

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a0c1c4
add URI format and target job name validation
pulkit-999 Mar 10, 2026
11f62dc
Update pkg/apis/trainer/v1alpha1/trainjob_types.go
pulkit-999 Mar 10, 2026
0015772
Merge branch 'master' into feat/add-storageuri-targetjob-validation
pulkit-999 Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/apis/trainer/v1alpha1/trainjob_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ type Initializer struct {
// which contains this label: `trainer.kubeflow.org/trainjob-ancestor-step: dataset-initializer`
type DatasetInitializer struct {
// storageUri is the URI for the dataset provider.
// Should be a valid URI format (e.g., s3://bucket/path, gs://bucket/path, /local/path)
// +kubebuilder:validation:Pattern=`^[a-zA-Z0-9+\-]+://.+|^/.*$`
// +optional
StorageUri *string `json:"storageUri,omitempty"`

Expand Down Expand Up @@ -291,6 +293,7 @@ type PodTemplateOverride struct {
type PodTemplateOverrideTargetJob struct {
// name is the target training job name for which the PodTemplateSpec is overridden.
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?$`
// +required
Name string `json:"name,omitempty"`
}
Expand Down
Loading