Skip to content

fix(ci): Generate valid release version for Python package#3333

Open
andreyvelich wants to merge 1 commit intokubeflow:masterfrom
andreyvelich:fix-python-release-version
Open

fix(ci): Generate valid release version for Python package#3333
andreyvelich wants to merge 1 commit intokubeflow:masterfrom
andreyvelich:fix-python-release-version

Conversation

@andreyvelich
Copy link
Member

We should correctly parse the version for Python package for RCs.

Ref: #2155

/cc @milinddethe15 @Krishna-kg732 @kubeflow/kubeflow-trainer-team

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copilot AI review requested due to automatic review settings March 13, 2026 23:43
@google-oss-prow google-oss-prow bot requested a review from milinddethe15 March 13, 2026 23:43
@google-oss-prow
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: Krishna-kg732, kubeflow/kubeflow-trainer-team.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

We should correctly parse the version for Python package for RCs.

Ref: #2155

/cc @milinddethe15 @Krishna-kg732 @kubeflow/kubeflow-trainer-team

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andreyvelich. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the project version to v2.2.0-rc.0 and aligns the generated Python SDK versioning with PEP 440 conventions for release candidates.

Changes:

  • Update root VERSION to v2.2.0-rc.0.
  • Adjust Python API generation to convert -rc.N into rcN for packageVersion.
  • Update Python SDK __version__ to 2.2.0rc0.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
VERSION Bumps repository version to v2.2.0-rc.0.
hack/python-api/gen-api.sh Normalizes VERSION into a Python/PEP440-compatible packageVersion for OpenAPI generator output.
api/python_api/kubeflow_trainer_api/__init__.py Updates the SDK __version__ to match the RC version format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants