Skip to content

fix(ci): Generate valid release version for Python package #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-oss-prow merged 1 commit into from
Mar 14, 2026
+3 −3
Merged

fix(ci): Generate valid release version for Python package #3333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Copy link
Member

@milinddethe15 milinddethe15 Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update VERSION when we cut this version?

Copy link
Member Author

@andreyvelich andreyvelich Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I will bump the version after.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
v2.1.0
v2.2.0-rc.0
2 changes: 1 addition & 1 deletion api/python_api/kubeflow_trainer_api/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion hack/python-api/gen-api.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ if [ ! -f "${VERSION_FILE}" ]; then
echo "Missing VERSION file at ${VERSION_FILE}"
exit 1
fi
API_VERSION=$(sed 's/^v//' "${VERSION_FILE}")
API_VERSION=$(sed -e 's/^v//' -e 's/-rc\.\([0-9]*\)/rc\1/' "${VERSION_FILE}")
API_OUTPUT_PATH="api/python_api"
PKG_ROOT="${API_OUTPUT_PATH}/kubeflow_trainer_api"

Expand Down
Loading