feat: add GitHub Actions workflow for linting and testing Helm charts#6184
feat: add GitHub Actions workflow for linting and testing Helm charts#6184SkalaNetworks merged 4 commits intokubeovn:masterfrom
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
5e7a239 to
63d8072
Compare
Pull Request Test Coverage Report for Build 21707915670Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
e44e2cc to
df7e360
Compare
53f1f2b to
b4377b6
Compare
|
I managed to get the first successful run. This means a successful @SkalaNetworks wdyt? |
SkalaNetworks
left a comment
There was a problem hiding this comment.
Thanks for the PR, have you tested this CI to see its results? I'm in interested in how it fails if linting or deploying doesn't work because of a broken commit.
|
@SkalaNetworks, this is nothing new and the same for all other workflows with kind involved. For example, here: https://github.com/kubeovn/kube-ovn/actions/runs/21705765236/job/62597476753 (Post Install kind) But I just realized that we have a basic installation (no linting) for the v1 chart in a workflow here: https://github.com/kubeovn/kube-ovn/blob/master/.github/workflows/build-x86-image.yaml#L1696 I think haveing it in a dedicated workflow is maybe better, or should we update the build-x86 to also run the tests for v2 chart? |
Signed-off-by: oujonny <jonny@immerda.ch>
…rt testing Signed-off-by: oujonny <jonny@immerda.ch>
|
I think a separate workflow makes everything cleaner |
6a3ccc7 to
f4c4b6f
Compare
Signed-off-by: oujonny <jonny@immerda.ch>
f4c4b6f to
70f16a1
Compare
|
@SkalaNetworks, I resolved your comments and would say this PR is ready now for a merge, or did I miss something? |
Signed-off-by: oujonny <jonny@immerda.ch>
|
LGTM, thank you, this will get merged shortly |
…kubeovn#6184) * feat: add GitHub Actions workflow for linting and testing Helm charts Signed-off-by: oujonny <jonny@immerda.ch> * feat: restrict GitHub Actions workflow to specific paths for Helm chart testing Signed-off-by: oujonny <jonny@immerda.ch> * fix: disable maintainers validation Signed-off-by: oujonny <jonny@immerda.ch> * fix: remove tmp values Signed-off-by: oujonny <jonny@immerda.ch> --------- Signed-off-by: oujonny <jonny@immerda.ch>
…kubeovn#6184) * feat: add GitHub Actions workflow for linting and testing Helm charts Signed-off-by: oujonny <jonny@immerda.ch> * feat: restrict GitHub Actions workflow to specific paths for Helm chart testing Signed-off-by: oujonny <jonny@immerda.ch> * fix: disable maintainers validation Signed-off-by: oujonny <jonny@immerda.ch> * fix: remove tmp values Signed-off-by: oujonny <jonny@immerda.ch> --------- Signed-off-by: oujonny <jonny@immerda.ch> Signed-off-by: Juan Morete <juan.morete@swisscom.com>
|
/gemini summary |
Summary of ChangesThis pull request establishes a new GitHub Actions workflow designed to enhance the continuous integration process for Helm charts. By automating linting and testing, it ensures that changes to the Highlights
Changelog
Ignored Files
Activity
|

Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)