Skip to content

feat: add GitHub Actions workflow for linting and testing Helm charts#6184

Merged
SkalaNetworks merged 4 commits intokubeovn:masterfrom
swisscom:feat/helm-testing
Feb 19, 2026
Merged

feat: add GitHub Actions workflow for linting and testing Helm charts#6184
SkalaNetworks merged 4 commits intokubeovn:masterfrom
swisscom:feat/helm-testing

Conversation

@oujonny
Copy link
Copy Markdown
Contributor

@oujonny oujonny commented Jan 20, 2026

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. chart Helm Chart github_actions Pull requests that update GitHub Actions code labels Jan 20, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 20, 2026

Pull Request Test Coverage Report for Build 21707915670

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1841 unchanged lines in 26 files lost coverage.
  • Overall coverage increased (+0.2%) to 23.034%

Files with Coverage Reduction New Missed Lines %
pkg/ovnmonitor/exporter.go 5 0.0%
pkg/controller/pod.go 6 9.91%
pkg/apis/kubeovn/v1/vpc-nat-gateway.go 8 0.0%
pkg/request/cniserver.go 8 0.0%
pkg/ovs/ovn-ic-nbctl.go 9 77.08%
pkg/ovs/ovs-appctl_linux.go 11 0.0%
pkg/daemon/flow_rules_linux.go 14 0.0%
pkg/speaker/eip.go 17 0.0%
pkg/util/vpc_nat_gateway.go 17 86.52%
pkg/controller/network_attachment.go 21 9.8%
Totals Coverage Status
Change from base Build 21161090554: 0.2%
Covered Lines: 12436
Relevant Lines: 53990

💛 - Coveralls

@oujonny oujonny force-pushed the feat/helm-testing branch 8 times, most recently from e44e2cc to df7e360 Compare January 20, 2026 09:15
@oujonny oujonny changed the title feat: add GitHub Actions workflow for linting and testing Helm charts Draft: feat: add GitHub Actions workflow for linting and testing Helm charts Jan 20, 2026
@oujonny oujonny marked this pull request as draft January 20, 2026 13:04
@oujonny oujonny force-pushed the feat/helm-testing branch 3 times, most recently from 53f1f2b to b4377b6 Compare January 20, 2026 14:54
@oujonny
Copy link
Copy Markdown
Contributor Author

oujonny commented Jan 20, 2026

I managed to get the first successful run. This means a successful lint and a helm install
see: https://github.com/kubeovn/kube-ovn/actions/runs/21176042613/job/60905034334#step:10:33

@SkalaNetworks wdyt?

Copy link
Copy Markdown
Member

@SkalaNetworks SkalaNetworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, have you tested this CI to see its results? I'm in interested in how it fails if linting or deploying doesn't work because of a broken commit.

@SkalaNetworks
Copy link
Copy Markdown
Member

image

The tests executed during this PR seem to fail but without triggering any error.

@oujonny
Copy link
Copy Markdown
Contributor Author

oujonny commented Feb 5, 2026

@SkalaNetworks, this is nothing new and the same for all other workflows with kind involved. For example, here: https://github.com/kubeovn/kube-ovn/actions/runs/21705765236/job/62597476753 (Post Install kind)

But I just realized that we have a basic installation (no linting) for the v1 chart in a workflow here: https://github.com/kubeovn/kube-ovn/blob/master/.github/workflows/build-x86-image.yaml#L1696

I think haveing it in a dedicated workflow is maybe better, or should we update the build-x86 to also run the tests for v2 chart?

…rt testing

Signed-off-by: oujonny <jonny@immerda.ch>
@SkalaNetworks
Copy link
Copy Markdown
Member

I think a separate workflow makes everything cleaner

@oujonny oujonny marked this pull request as ready for review February 17, 2026 12:48
@oujonny oujonny force-pushed the feat/helm-testing branch 2 times, most recently from 6a3ccc7 to f4c4b6f Compare February 17, 2026 13:02
Signed-off-by: oujonny <jonny@immerda.ch>
@oujonny oujonny changed the title Draft: feat: add GitHub Actions workflow for linting and testing Helm charts feat: add GitHub Actions workflow for linting and testing Helm charts Feb 17, 2026
@oujonny
Copy link
Copy Markdown
Contributor Author

oujonny commented Feb 17, 2026

@SkalaNetworks, I resolved your comments and would say this PR is ready now for a merge, or did I miss something?

@SkalaNetworks SkalaNetworks self-assigned this Feb 18, 2026
Signed-off-by: oujonny <jonny@immerda.ch>
@SkalaNetworks
Copy link
Copy Markdown
Member

LGTM, thank you, this will get merged shortly

@SkalaNetworks SkalaNetworks merged commit dedad47 into kubeovn:master Feb 19, 2026
72 of 78 checks passed
morete pushed a commit to swisscom/kube-ovn that referenced this pull request Feb 19, 2026
…kubeovn#6184)

* feat: add GitHub Actions workflow for linting and testing Helm charts

Signed-off-by: oujonny <jonny@immerda.ch>

* feat: restrict GitHub Actions workflow to specific paths for Helm chart testing

Signed-off-by: oujonny <jonny@immerda.ch>

* fix: disable maintainers validation

Signed-off-by: oujonny <jonny@immerda.ch>

* fix: remove tmp values

Signed-off-by: oujonny <jonny@immerda.ch>

---------

Signed-off-by: oujonny <jonny@immerda.ch>
morete pushed a commit to swisscom/kube-ovn that referenced this pull request Feb 19, 2026
…kubeovn#6184)

* feat: add GitHub Actions workflow for linting and testing Helm charts

Signed-off-by: oujonny <jonny@immerda.ch>

* feat: restrict GitHub Actions workflow to specific paths for Helm chart testing

Signed-off-by: oujonny <jonny@immerda.ch>

* fix: disable maintainers validation

Signed-off-by: oujonny <jonny@immerda.ch>

* fix: remove tmp values

Signed-off-by: oujonny <jonny@immerda.ch>

---------

Signed-off-by: oujonny <jonny@immerda.ch>
Signed-off-by: Juan Morete <juan.morete@swisscom.com>
@oujonny
Copy link
Copy Markdown
Contributor Author

oujonny commented Feb 23, 2026

/gemini summary

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

This pull request establishes a new GitHub Actions workflow designed to enhance the continuous integration process for Helm charts. By automating linting and testing, it ensures that changes to the kube-ovn-v2 chart meet quality standards and function correctly before being merged, thereby improving the overall reliability and maintainability of the project's Helm deployments.

Highlights

  • New GitHub Actions Workflow: Introduced a dedicated GitHub Actions workflow to automate linting and testing of Helm charts, specifically for kube-ovn-v2.
  • Helm Chart Version Update: Updated the kube-ovn-v2 Helm chart version from v1.16.0 to v1.16.1.
Changelog
  • charts/kube-ovn-v2/Chart.yaml
    • Updated the chart version from v1.16.0 to v1.16.1.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/helm-testing.yaml
Activity
  • gemini-code-assist[bot] noted an inability to generate a summary due to unsupported file types.
  • coveralls provided a test coverage report, including a warning about an inaccurate base commit.
  • oujonny reported the first successful run of the new workflow (lint and helm install) and requested feedback from SkalaNetworks.
  • SkalaNetworks observed that tests appeared to fail without triggering explicit errors.
  • oujonny discussed existing kind workflows and proposed keeping the new Helm testing in a dedicated workflow rather than integrating it into build-x86-image.yaml.
  • SkalaNetworks agreed that a separate workflow provides a cleaner solution.
  • oujonny confirmed that all previous comments were addressed and the PR was ready for merge.
  • SkalaNetworks provided an LGTM (Looks Good To Me) and indicated the PR would be merged shortly.
  • A discussion occurred regarding the maintainers field in Chart.yaml, leading to its removal and disabling of related validation.
  • The workflow's trigger conditions were refined to activate only when changes are made within the charts/* directory, specifically for the v2 chart.
  • Clarification was provided on the helm-diff command, confirming it runs on every PR and compares against the default branch as intended.
  • A comment was requested to be removed.
  • A conversation took place comparing the benefits of a full helm install with a kind cluster versus a simpler helm template dry-run for testing, with the decision to retain the helm install approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart Helm Chart ci github_actions Pull requests that update GitHub Actions code size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants