Revert "refactor: move nodeDriverRegistrar config under node section"#1100
Merged
andyzhangx merged 1 commit intokubernetes-csi:masterfrom Apr 17, 2026
Merged
Conversation
This reverts the change from PR kubernetes-csi#1087 which moved nodeDriverRegistrar config from top-level to under the node section. Moving it back to top-level for backward compatibility with existing chart consumers.
Contributor
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
kind/cleanup
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
andyzhangx
removed
the
do-not-merge/release-note-label-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Reverts #1087 — moves
nodeDriverRegistrarconfig back to top-level invalues.yamlfor backward compatibility with existing chart consumers.Changes:
values.yaml: movenodeDriverRegistrarblock back to top-level (out ofnodesection)csi-nfs-node.yaml: revert template refs from.Values.node.nodeDriverRegistrarto.Values.nodeDriverRegistrarcharts/README.md: update parameter documentation