feat: add --timeout flag for node-driver-registrar#1105
Merged
andyzhangx merged 1 commit intokubernetes-csi:masterfrom Apr 18, 2026
Merged
feat: add --timeout flag for node-driver-registrar#1105andyzhangx merged 1 commit intokubernetes-csi:masterfrom
andyzhangx merged 1 commit intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
andyzhangx
force-pushed
the
add-registrar-timeout
branch
from
d9e65c6 to
e4e8b9d
Compare
Add configurable timeout for node driver registrar gRPC connection to the CSI driver socket. Default increased from 10s to 60s to prevent unnecessary container restarts when nfsplugin takes longer to initialize and create the CSI socket. Ref 1065
andyzhangx
force-pushed
the
add-registrar-timeout
branch
from
e4e8b9d to
21de9bc
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
andyzhangx
added a commit
to andyzhangx/csi-driver-nfs
that referenced
this pull request
Apr 18, 2026
…timeout feat: add --timeout flag for node-driver-registrar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a configurable
--timeoutflag for node-driver-registrar in the Helm chart (nodeDriverRegistrar.timeout) and deploy manifests. Default is increased from 10s to 60s.During node DaemonSet startup, node-driver-registrar can start before nfsplugin has created the CSI socket (
/csi/csi.sock). With the default 10s timeout, the registrar exits withcontext deadline exceededand restarts unnecessarily. Increasing the timeout to 60s gives the nfs plugin sufficient time to initialize, avoiding the crash-restart cycle.Which issue(s) this PR fixes:
Fixes #1065
Special notes for your reviewer:
Changes:
charts/latest/csi-driver-nfs/values.yaml: AddednodeDriverRegistrar.timeout: 60charts/latest/csi-driver-nfs/templates/csi-nfs-node.yaml: Added--timeout={{ .Values.nodeDriverRegistrar.timeout }}sargdeploy/v4.13.2/csi-nfs-node.yaml: Added--timeout=60sargDoes this PR introduce a user-facing change?