Skip to content

add bats tests and fix udp on mac and windows#230

Merged
aojea merged 1 commit intokubernetes-sigs:mainfrom
aojea:bats_tests
Apr 18, 2025
Merged

add bats tests and fix udp on mac and windows#230
aojea merged 1 commit intokubernetes-sigs:mainfrom
aojea:bats_tests

Conversation

@aojea
Copy link
Copy Markdown
Contributor

@aojea aojea commented Apr 17, 2025 •
edited
Loading

Allow to forward UDP on Mac and Windows

Co-author-by: @imchristianlowe

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from stmcginnis April 17, 2025 15:41
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2025
@aojea aojea mentioned this pull request Apr 17, 2025
Merged
@aojea aojea force-pushed the bats_tests branch 5 times, most recently from 27cf4c0 to 773b1d7 Compare April 17, 2025 16:01
BenTheElder
BenTheElder reviewed Apr 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, are we using external bash libraries? wheee

BenTheElder
BenTheElder reviewed Apr 17, 2025
View reviewed changes
@aojea aojea force-pushed the bats_tests branch 10 times, most recently from 2c6931e to 593a3cc Compare April 18, 2025 09:36
@aojea aojea changed the title add bats tests add bats tests and fix udp on mac and windows Apr 18, 2025
@aojea
Copy link
Copy Markdown
Contributor Author

aojea commented Apr 18, 2025

wait, are we using external bash libraries? wheee

what do you mean?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 18, 2025

@aojea: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-kind-conformance-parallel-ga-only a412794 link false /test pull-cloud-provider-kind-conformance-parallel-ga-only
pull-cloud-provider-kind-conformance-parallel-ipv6 a412794 link false /test pull-cloud-provider-kind-conformance-parallel-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aojea @imchristianlowe
feature: UDP loadbalancers on Windows and Macos
e6eecca 
Implement loadbalancers on those platforms that require to setup a
tunnel on the host.

Co-authored-by: Christian Lowe <imchristianlowe@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2025
@imchristianlowe
Copy link
Copy Markdown
Contributor

imchristianlowe commented Apr 18, 2025

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 18, 2025

@imchristianlowe: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aojea aojea merged commit 1085e8b into kubernetes-sigs:main Apr 18, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aojea @k8s-ci-robot @imchristianlowe @BenTheElder