Skip to content

🐛 Release notes for rc0 shall be generated as other RC builds#13301

Open
irapandey wants to merge 1 commit intokubernetes-sigs:mainfrom
irapandey:release-notes-rc0
Open

🐛 Release notes for rc0 shall be generated as other RC builds#13301
irapandey wants to merge 1 commit intokubernetes-sigs:mainfrom
irapandey:release-notes-rc0

Conversation

@irapandey
Copy link
Member

@irapandey irapandey commented Feb 3, 2026 •
edited
Loading

What this PR does / why we need it:
The release notes for first RC builds i.e. rc0 is generated by comparing to main which has led to issues in past. This PR modifies that to generate the release notes for rc0 the same as the rest of the RC builds.

% RELEASE_TAG=v1.10.0-rc.0 make release-notes
fatal: No names found, cannot describe anything.
go build -C hack/tools -o /Users/ira/OpenSource/cluster-api/bin/notes -tags tools sigs.k8s.io/cluster-api/hack/tools/release/notes
./bin/notes --release v1.10.0-rc.0 --previous-release-version "" > CHANGELOG/v1.10.0-rc.0.md
2026/02/03 14:07:07 Computing diff between tags/v1.9.0 and heads/release-1.10

Computing diff between tags/v1.9.0 and heads/release-1.10

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12277

/area release
/area testing

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Feb 3, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2026
@irapandey
Copy link
Member Author

irapandey commented Feb 3, 2026

Hey @chandankumar4 - PTAL

@irapandey
Copy link
Member Author

irapandey commented Feb 3, 2026

/area release
/area testing

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing area/testing Issues or PRs related to testing and removed do-not-merge/needs-area PR is missing an area label labels Feb 3, 2026
chandankumar4
chandankumar4 approved these changes Feb 8, 2026
View reviewed changes
Copy link
Contributor

@chandankumar4 chandankumar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 8, 2026

LGTM label has been added.

DetailsGit tree hash: 8aaf1118256d83eae90c5a23568646d1d768d8df

@irapandey
Copy link
Member Author

irapandey commented Feb 11, 2026

/assign @vincepri

sbueringer
sbueringer reviewed Feb 11, 2026
View reviewed changes
hack/tools/release/notes/main.go
} else if len(newTag.Pre) == 2 && newTag.Pre[0].VersionStr == "rc" && newTag.Pre[1].VersionNum >= 1 {
// for the second or later RCs, we use the release branch since we cut this branch with the first RC
} else if len(newTag.Pre) == 2 && newTag.Pre[0].VersionStr == "rc" {
// for all RCs (including rc.0), we use the release branch so notes are generated
Copy link
Member

@sbueringer sbueringer Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this means we have to push the release branch before you can generate the release notes?

But the release branch and the release tag is only created by the release action after we merge the PR with the release notes?

Copy link
Member Author

@irapandey irapandey Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar concern but I wasn't familiar with the release flow - Thanks for the insight.
I suppose this opens a discussion, looping in @chandankumar4

Copy link
Member Author

@irapandey irapandey Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug arose with generation of release notes for v1.10.0-rc.0 - This issue was added in the improvement board for release 1.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@anshuman-agarwala anshuman-agarwala Awaiting requested review from anshuman-agarwala

@wendy-ha18 wendy-ha18 Awaiting requested review from wendy-ha18

+1 more reviewer

@chandankumar4 chandankumar4 chandankumar4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vincepri vincepri

@chandankumar4 chandankumar4

Labels

area/release Issues or PRs related to releasing area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix release notes generated for rc.0 tag

5 participants

@irapandey @k8s-ci-robot @sbueringer @chandankumar4 @vincepri