Skip to content

🐛 Release notes for rc0 shall be generated as other RC builds #13301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irapandey wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

🐛 Release notes for rc0 shall be generated as other RC builds #13301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions hack/tools/release/notes/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,13 +277,14 @@ func defaultBranchForNewTag(newTag semver.Version) string {
if len(newTag.Pre) == 0 {
// for new minor releases, use the release branch
return releaseBranchForVersion(newTag)
} else if len(newTag.Pre) == 2 && newTag.Pre[0].VersionStr == "rc" && newTag.Pre[1].VersionNum >= 1 {
// for the second or later RCs, we use the release branch since we cut this branch with the first RC
} else if len(newTag.Pre) == 2 && newTag.Pre[0].VersionStr == "rc" {
// for all RCs (including rc.0), we use the release branch so notes are generated
Copy link
Member

@sbueringer sbueringer Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this means we have to push the release branch before you can generate the release notes?

But the release branch and the release tag is only created by the release action after we merge the PR with the release notes?

Copy link
Member Author

@irapandey irapandey Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar concern but I wasn't familiar with the release flow - Thanks for the insight.
I suppose this opens a discussion, looping in @chandankumar4

Copy link
Member Author

@irapandey irapandey Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug arose with generation of release notes for v1.10.0-rc.0 - This issue was added in the improvement board for release 1.13

// the same way: previous minor to release branch (not previous minor to main)
return releaseBranchForVersion(newTag)
}

// for any other pre release, we always cut from main
// this includes all beta releases and the first RC
// this includes all beta releases
return "main"
}

Expand Down
2 changes: 1 addition & 1 deletion hack/tools/release/notes/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func Test_defaultBranchForNewTag(t *testing.T) {
{
name: "first RC",
newVersion: "v1.6.0-rc.0",
want: "main",
want: "release-1.6",
},
{
name: "second RC",
Expand Down