[WIP] ✨ Create kube-state-metrics configuration from markers by chrischdi · Pull Request #9347 · kubernetes-sigs/cluster-api

chrischdi · 2023-08-31T15:07:23Z

What this PR does / why we need it:

Makes use of kube-state-metrics PR kubernetes/kube-state-metrics#2014 to generate the configuration for the CRD metrics.

TODO:

wait for ✨ metrics: add generator for kube-state-metrics customresource configuration controller-tools#1043 to merge
squash

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7158

For testing:

checkout the controller-tools branch
Build the binary and move it over to hack/tools/bin: go build ./cmd/controller-gen && cp controller-gen ../cluster-api/hack/tools/bin/controller-gen-v0.16.1

/area ci

k8s-triage-robot · 2024-01-21T16:20:54Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-25T17:34:27Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

chrischdi · 2024-02-26T09:12:51Z

/remove-lifecycle rotten

k8s-triage-robot · 2024-05-26T09:34:17Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-06-26T08:10:34Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-07-26T08:32:34Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-07-26T08:32:39Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2024-07-26T11:49:47Z

/reopen

k8s-ci-robot · 2024-07-26T11:49:52Z

@chrischdi: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…w generated one

k8s-ci-robot · 2025-03-20T15:06:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chrischdi. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…nsionconfig ipaddressclaim and crs

k8s-ci-robot · 2025-03-20T15:49:37Z

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-verify-main	`bb7541d`	link	true	`/test pull-cluster-api-verify-main`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-triage-robot · 2025-04-19T16:33:41Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-04-19T16:33:46Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-04-19T16:33:50Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2025-08-15T08:45:38Z

/reopen

k8s-ci-robot · 2025-08-15T08:45:43Z

@chrischdi: Failed to re-open PR: state cannot be changed. The experiment-metrics-gen-flags branch was force-pushed or recreated.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/ci Issues or PRs related to ci labels Aug 31, 2023

k8s-ci-robot requested a review from killianmuldoon August 31, 2023 15:07

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2023

k8s-ci-robot requested a review from richardcase August 31, 2023 15:07

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 31, 2023

chrischdi force-pushed the experiment-metrics-gen-flags branch from a6c3d6b to 0648b32 Compare September 8, 2023 19:26

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2023

cprivitere mentioned this pull request Jan 9, 2024

Add kube-state-metrics support kubernetes-retired/cluster-api-provider-packet#708

Closed

6 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 25, 2024

chrischdi closed this Feb 26, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 26, 2024

chrischdi reopened this Feb 26, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2024

chrischdi marked this pull request as draft May 27, 2024 08:06

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 26, 2024

k8s-ci-robot closed this Jul 26, 2024

k8s-ci-robot reopened this Jul 26, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 18, 2025

chrischdi added 9 commits March 20, 2025 15:49

api: add markers for metrics to api types

dc9bec5

add v1beta2 conditions

ef8cb8b

metrics: drop templates for metrics generation and rename yaml files

4843862

metrics: sort entries in metrics.yaml for better comparison to the ne…

2f685df

…w generated one

metrics: adjust generate-metrics-config to use controller-gen

d4cbd49

DROPME: use controller-gen from fork

1d270f6

metrics: regenerate

560dd76

fixup! DROPME: use controller-gen from fork

179e183

first step for v1beta2 dashboards

3b9b68f

chrischdi force-pushed the experiment-metrics-gen-flags branch from 4e61080 to 3b9b68f Compare March 20, 2025 15:06

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2025

chrischdi mentioned this pull request Mar 20, 2025

🌱 metrics: use v1beta2 for condition metrics and add metrics for dockercluster devcluster dockermachine devmachine extensionconfig ipaddressclaim and crs #12006

Merged

chrischdi added 5 commits March 20, 2025 16:28

add markers to dockercluster devcluster dockermachine devmachine exte…

a8ee478

…nsionconfig ipaddressclaim and crs

update Makefile for api directories

c427a0d

regenerate

51d8c61

drop v1beta1 conditions and rename v1beta2 conditions metric

511f612

regenerate

bb7541d

chrischdi mentioned this pull request Apr 12, 2025

Automate generation of kube-state-metrics configuration #7158

Open

k8s-ci-robot closed this Apr 19, 2025

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2025

chrischdi mentioned this pull request Aug 15, 2025

[WIP] ✨ Create kube-state-metrics configuration from markers #12641

Closed

2 tasks

Conversation

chrischdi commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-triage-robot commented Jan 21, 2024

Uh oh!

k8s-triage-robot commented Feb 25, 2024

Uh oh!

chrischdi commented Feb 26, 2024

Uh oh!

k8s-triage-robot commented May 26, 2024

Uh oh!

k8s-triage-robot commented Jun 26, 2024

Uh oh!

k8s-triage-robot commented Jul 26, 2024

Uh oh!

k8s-ci-robot commented Jul 26, 2024

Uh oh!

chrischdi commented Jul 26, 2024

Uh oh!

k8s-ci-robot commented Jul 26, 2024

Uh oh!

k8s-ci-robot commented Mar 20, 2025

Uh oh!

k8s-ci-robot commented Mar 20, 2025

Uh oh!

k8s-triage-robot commented Apr 19, 2025

Uh oh!

k8s-ci-robot commented Apr 19, 2025

Uh oh!

k8s-ci-robot commented Apr 19, 2025

Uh oh!

chrischdi commented Aug 15, 2025

Uh oh!

k8s-ci-robot commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chrischdi commented Aug 31, 2023 •

edited

Loading