Skip to content

✨ Add support for external ApplyConfiguration mappings#1327

Merged
k8s-ci-robot merged 6 commits intokubernetes-sigs:mainfrom
andrew-farries:external-acs
Feb 17, 2026
Merged

✨ Add support for external ApplyConfiguration mappings#1327
k8s-ci-robot merged 6 commits intokubernetes-sigs:mainfrom
andrew-farries:external-acs

Conversation

@andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Jan 19, 2026

Add support for external ApplyConfiguration mappings.

#818 added support for generation of ApplyConfigurations, but left support for external ApplyConfiguration mappings to be done as a follow-up [comment]. This PR adds that support.

Specifying the mapping between external types and their ApplyConfigurations is done using the new externalApplyConfigurations option on the applyconfiguration generator:

controller-gen applyconfiguration:externalApplyConfigurations=<package>.<TypeName>@<applyconfiguration-package>

where <package>.<TypeName> is the package-qualified type name whose ApplyConfiguration types reside in <applyconfiguration-package>.

Fixes #1298

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 19, 2026 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 19, 2026

Welcome @andrew-farries!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 19, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 19, 2026

Hi @andrew-farries. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 19, 2026
@andrew-farries andrew-farries mentioned this pull request Jan 28, 2026
Closed
@sbueringer
Copy link
Member

sbueringer commented Jan 28, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2026
@andrew-farries
Add support for external apply configurations
677dbf0
@andrew-farries
Generate help for external AC marker
d8a0ded 
Using:

```
go generate ./cmd/controller-gen/...
```
@andrew-farries
Add testdata/external and testdata/externalac
ab00b66 
Add packages under `testdata` that define an external type to be used
for testing applyconfiguration generation for types that reference
external types.
@andrew-farries
Add EmbeddedExternalSpec to cronjob_types.go
5abdfff 
This type is used to test generation of ACs for types that embed
external types.
@andrew-farries
Update testdata with generated ACs
f5a4a09 
Run the tests with `UPDATE=1` to regenerate the testdata files.
@andrew-farries
Update existing AC generator tests
6ec734c 
Pass the `externalApplyConfigurations` option to the
`applyconfiguration` generator in the other tests so that they correctly
generate `ApplyConfiguration` types now that an external type is used in
the `CronJob`.
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 13, 2026
@sbueringer
Copy link
Member

sbueringer commented Feb 13, 2026

Thx!

/lgtm

/assign @alvaroaleman @JoelSpeed

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 13, 2026

LGTM label has been added.

DetailsGit tree hash: 483657e3d6a6b59399fad3c90201d03cea9c5df4

alvaroaleman
alvaroaleman approved these changes Feb 17, 2026
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, andrew-farries

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2026
@k8s-ci-robot k8s-ci-robot merged commit a730752 into kubernetes-sigs:main Feb 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

@alvaroaleman alvaroaleman

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken ApplyConfiguration when embedding an external struct

5 participants

@andrew-farries @k8s-ci-robot @sbueringer @alvaroaleman @JoelSpeed