Skip to content

🌱 fix and test webhook testdata compilation #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Feb 17, 2026
+13 −2,090
Merged

🌱 fix and test webhook testdata compilation #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/loader/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,10 @@ func (l *loader) typeCheck(pkg *Package) {
illTyped := len(errs) > 0
if !illTyped {
for _, importedPkg := range pkg.Imports() {
if importedPkg.IllTyped {
importedPkg.Lock()
isIllTyped := importedPkg.IllTyped
importedPkg.Unlock()
if isIllTyped {
illTyped = true
break
}
Expand Down
86 changes: 0 additions & 86 deletions pkg/webhook/testdata/cronjob_types.go
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions pkg/webhook/testdata/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
module testdata.kubebuilder.io/cronjob

go 1.15

require (
k8s.io/api v0.19.2
k8s.io/apimachinery v0.19.2
sigs.k8s.io/controller-runtime v0.7.0
)
go 1.25.0
720 changes: 0 additions & 720 deletions pkg/webhook/testdata/go.sum
View file
Open in desktop

Large diffs are not rendered by default.

71 changes: 0 additions & 71 deletions pkg/webhook/testdata/invalid-admissionReviewVersionsRequired/cronjob_types.go
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions pkg/webhook/testdata/invalid-admissionReviewVersionsRequired/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,36 +15,6 @@ limitations under the License.

package cronjob

import (
"k8s.io/apimachinery/pkg/runtime"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/webhook"
)

func (c *CronJob) SetupWebhookWithManager(mgr ctrl.Manager) error {
return ctrl.NewWebhookManagedBy(mgr).
For(c).
Complete()
}

// +kubebuilder:webhook:webhookVersions=v1,verbs=create;update,path=/validate-testdata-kubebuilder-io-v1-cronjob,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=validation.cronjob.testdata.kubebuilder.io,sideEffects=None,timeoutSeconds=10
// +kubebuilder:webhook:verbs=create;update,path=/validate-testdata-kubebuilder-io-v1-cronjob,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=validation.cronjob.testdata.kubebuilder.io,sideEffects=NoneOnDryRun,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1
// +kubebuilder:webhook:webhookVersions=v1,verbs=create;update,path=/mutate-testdata-kubebuilder-io-v1-cronjob,mutating=true,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=default.cronjob.testdata.kubebuilder.io,sideEffects=None,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1

var _ webhook.Defaulter = &CronJob{}
var _ webhook.Validator = &CronJob{}

func (c *CronJob) Default() {
}

func (c *CronJob) ValidateCreate() error {
return nil
}

func (c *CronJob) ValidateUpdate(_ runtime.Object) error {
return nil
}

func (c *CronJob) ValidateDelete() error {
return nil
}
71 changes: 0 additions & 71 deletions pkg/webhook/testdata/invalid-multiple-webhookconfigurations/cronjob_types.go
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions pkg/webhook/testdata/invalid-multiple-webhookconfigurations/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,38 +15,8 @@ limitations under the License.

package cronjob

import (
"k8s.io/apimachinery/pkg/runtime"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/webhook"
)

func (c *CronJob) SetupWebhookWithManager(mgr ctrl.Manager) error {
return ctrl.NewWebhookManagedBy(mgr).
For(c).
Complete()
}

// +kubebuilder:webhook:webhookVersions=v1,verbs=create;update,path=/validate-testdata-kubebuilder-io-v1-cronjob,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=validation.cronjob.testdata.kubebuilder.io,sideEffects=None,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1
// +kubebuilder:webhook:verbs=create;update,path=/validate-testdata-kubebuilder-io-v1-cronjob,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=validation.cronjob.testdata.kubebuilder.io,sideEffects=NoneOnDryRun,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1
// +kubebuilder:webhook:webhookVersions=v1,verbs=create;update,path=/mutate-testdata-kubebuilder-io-v1-cronjob,mutating=true,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=default.cronjob.testdata.kubebuilder.io,sideEffects=None,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1,reinvocationPolicy=IfNeeded
// +kubebuilder:webhookconfiguration:mutating=true,name=foo
// +kubebuilder:webhookconfiguration:mutating=true,name=bar

var _ webhook.Defaulter = &CronJob{}
var _ webhook.Validator = &CronJob{}

func (c *CronJob) Default() {
}

func (c *CronJob) ValidateCreate() error {
return nil
}

func (c *CronJob) ValidateUpdate(_ runtime.Object) error {
return nil
}

func (c *CronJob) ValidateDelete() error {
return nil
}
Loading
Loading