🌱 fix and test webhook testdata compilation#1345
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Feb 17, 2026
Merged
🌱 fix and test webhook testdata compilation#1345k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
approved
alvaroaleman
commented
Feb 16, 2026
|
|
||
| var _ webhook.Defaulter = &CronJob{} | ||
| var _ webhook.Validator = &CronJob{} | ||
| var _ admission.Defaulter[*cronjobv1.CronJob] = &webhook{} |
Member
Author
There was a problem hiding this comment.
I am also wondering if we even need any of this code...Would it be enough to just have an empty go file with the comments?
Member
Author
There was a problem hiding this comment.
We do not, so just removing it all
alvaroaleman
force-pushed
the
fix-bump
branch
from
6cf93e4 to
0e7818f
Compare
alvaroaleman
changed the title
alvaroaleman
force-pushed
the
fix-bump
branch
from
0e7818f to
cd9ca8d
Compare
The webhook testdata used a very old controller-runtime version but fundamentally doesn't actually need any code, as the tests only require the markers, so just kill it all.
alvaroaleman
force-pushed
the
fix-bump
branch
from
cd9ca8d to
42f10e1
Compare
Member
|
Nice cleanup, thx! /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: fc48fc083ae7fa4a0ed7922968cd7559d04188b5 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webhook testdata used a very old controller-runtime version but
fundamentally doesn't actually need any code, as the tests only require
the markers, so just kill it all.