fix new staticcheck failure reported by golangci-lint v2.10.1

[tariq1890]

This PR addresses the following lint failure:

Error: cmd/compute-domain-daemon/dnsnames.go:179:3: QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(...)) (staticcheck)
  		newHostsContent.WriteString(fmt.Sprintf("%s\t%s\n", ip, dnsName))
  		^
  1 issues:
  * staticcheck: 1

[shivamerla]

LGTM

[klueska]

This should not have been merged without a milestone, a proper set of labels, and an initiative set for it.

[tariq1890]

@klueska I was not aware. Please note that this change is needed to unblock our CI since golangci-lint has started complain (we don't pin the golangci-lint version in this repo)

I assume this is for release note purposes?

[jgehrcke]

Of course this was an important change. I want to express my strong opinions about process here.

this change is needed to unblock our CI since golangci-lint has started complain (we don't pin the golangci-lint version in this repo)

Here's how I always prefer to do this. Based on an ever-repeating situation across companies and teams. I dislike urgent PRs that

• don't themselves describe how urgent they are, and why
• don't feed into a data collection system (issues, with labels)

Especially when there's multiple people watching a repo across timezones. Slack threads behind the scenes don't count for context. Issue tracker is the source of truth, in particular in the heat of the moment.

Here, an issue should point out that main is broken. That's how we should start! :) We have a label for that:

Example: #688

Then, the PR can link to the issue.

we don't pin the golangci-lint version in this repo

My strong opinion: we should! For exactly this reason. Even when trying hard, a CI pipeline is never static over time (degrades with time). But still, one should try hard to eliminate individual moving targets one by one. To me, pinning a linter to a specific version is a rather obvious decision (it should of course still be bumped regularly, just at a self-chosen point in time, with control).