Skip to content

WIP chore(provider): inline providers first steps #5312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Apr 21, 2025

Description

It's most likely a good idea to inline providers, this will help to simplify operational support, and add support for --provider-<flag> instead of --<provider-name>-<flag> and similar

In this pull request

  • renamed custom TTL constansts to defaultTTL
  • removed declaration shadowing
  • empty slice declarations using literals

Ideally providers should support

  • DryRun
  • ApiRate limiting
  • Page Size
  • TTL
  • Caching

Relates

follow-up:

  • rename DryRun to dryRun where required
  • review what else as common values we could add to docs

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: ivan katliarchuk <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 21, 2025
Signed-off-by: ivan katliarchuk <[email protected]>
@ivankatliarchuk
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 21, 2025
@ivankatliarchuk ivankatliarchuk changed the title chore(provider): inline providers chore(provider): inline providers first steps Apr 22, 2025
@mloiseleur
Copy link
Collaborator

@ivankatliarchuk It's a good step !

The part renamed custom TTL constansts to defaultTTL is quite huge. Would you please set it into a separate PR, so the other changes can be (more) easily reviewed ?

@ivankatliarchuk ivankatliarchuk changed the title chore(provider): inline providers first steps WIP chore(provider): inline providers first steps Apr 23, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2025
@ivankatliarchuk ivankatliarchuk marked this pull request as draft April 23, 2025 08:16
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants