Skip to content

Conversation

@u-kai
Copy link
Contributor

@u-kai u-kai commented Dec 14, 2025

What does it do ?

This PR introduces a new flag, --txt-prefix-override, as a safe and flexible workaround
to support apex domains when using the TXT registry.

The flag allows users to override the TXT record prefix per domain by specifying
one or more mappings in the following form:

--txt-prefix-override=domain=txt-prefix

Multiple overrides can be provided, and each mapping applies only to the explicitly
specified domain.

Motivation

In #5864, we discussed limitations and edge cases around managing apex domains with the
TXT registry.

While a flag such as --apex-domains was considered, it was intentionally avoided for
the following reasons:

  • A flag named --apex-domains could be misunderstood as applying special behavior to
    all apex domains automatically.
  • The underlying problem is not limited to apex domains; it is more generally about
    domain-specific TXT prefix customization.
  • Introducing a domain-scoped override mechanism keeps the behavior explicit and avoids
    surprising users.

By using --txt-prefix-override, users must opt in per domain, making the behavior
clear and predictable.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the apis Issues or PRs related to API change label Dec 14, 2025
@k8s-ci-robot k8s-ci-robot added controller Issues or PRs related to the controller docs internal Issues or PRs related to internal code needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. plan Issues or PRs related to external-dns plan labels Dec 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @u-kai. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added registry Issues or PRs related to a registry size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 14, 2025
@u-kai u-kai changed the title Feat/support overrides txt prefix feat: add --txt-prefix-override flag to support apex domains safely Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apis Issues or PRs related to API change cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. controller Issues or PRs related to the controller docs internal Issues or PRs related to internal code needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. plan Issues or PRs related to external-dns plan registry Issues or PRs related to a registry size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants