feat: add --txt-prefix-override flag to support apex domains safely #6026
+695
−229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
This PR introduces a new flag,
--txt-prefix-override, as a safe and flexible workaroundto support apex domains when using the TXT registry.
The flag allows users to override the TXT record prefix per domain by specifying
one or more mappings in the following form:
Multiple overrides can be provided, and each mapping applies only to the explicitly
specified domain.
Motivation
In #5864, we discussed limitations and edge cases around managing apex domains with the
TXT registry.
While a flag such as
--apex-domainswas considered, it was intentionally avoided forthe following reasons:
--apex-domainscould be misunderstood as applying special behavior toall apex domains automatically.
domain-specific TXT prefix customization.
surprising users.
By using
--txt-prefix-override, users must opt in per domain, making the behaviorclear and predictable.
More