Skip to content

refactor(plan): extract normalizeDNSName to idna package for reuse #6043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 21, 2025
Merged

refactor(plan): extract normalizeDNSName to idna package for reuse #6043

k8s-ci-robot merged 1 commit into from
Dec 21, 2025
+115 −113

Conversation

@u-kai
Copy link
Contributor

@u-kai u-kai commented Dec 19, 2025

What does it do ?

This PR moves normalizeDNSName to a dedicated package and makes it a public function.

Motivation

This function is conceptually shared logic and fits better in a more appropriate package.

In addition, it will be reused by a follow-up PR that introduces behavior changes relying on the same DNS normalization logic.
Separating this change allows that PR to focus purely on behavior, while keeping this one scoped to code organization and reuse.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the internal Issues or PRs related to internal code label Dec 19, 2025
@k8s-ci-robot k8s-ci-robot requested a review from szuecs December 19, 2025 23:40
@k8s-ci-robot k8s-ci-robot added plan Issues or PRs related to external-dns plan cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 19, 2025

Hi @u-kai. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 19, 2025
@u-kai u-kai mentioned this pull request Dec 19, 2025
Open
3 tasks
@ivankatliarchuk
Copy link
Member

ivankatliarchuk commented Dec 19, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 19, 2025
@coveralls
Copy link

coveralls commented Dec 19, 2025

Pull Request Test Coverage Report for Build 20385454698

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on refactor/dns-normalized at 78.692%
Totals Coverage Status
Change from base Build 20368853975: 78.7%
Covered Lines: 16021
Relevant Lines: 20359
💛 - Coveralls

@ivankatliarchuk
Copy link
Member

ivankatliarchuk commented Dec 19, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2025
@mloiseleur mloiseleur changed the title refactor: extract normalizeDNSName to idna package for reuse refactor(plan): extract normalizeDNSName to idna package for reuse Dec 21, 2025
mloiseleur
mloiseleur approved these changes Dec 21, 2025
View reviewed changes
Copy link
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 029df94 into kubernetes-sigs:master Dec 21, 2025
23 checks passed
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Dec 28, 2025
@ivankatliarchuk
Merge branch 'master' into docs-add-tutorial-aws-localstack
489bba1 
* master:
  somehow single test was not fixed (kubernetes-sigs#6059)
  refactore(registry): move registry selector to registry package (kubernetes-sigs#6047)
  fix(domain-exclusion): domain exclusion filter fix (kubernetes-sigs#6050)
  chore(wrapper): centralized endpoint validation (kubernetes-sigs#6041)
  test(coverage): improve code coverage for different files (kubernetes-sigs#6045)
  chore(lint): configure modernize linter (kubernetes-sigs#6035)
  docs(proposal): Gateway API annotation placement clarity proposal (kubernetes-sigs#5919)
  fix(scripts): helm plugins install disable verify (kubernetes-sigs#6057)
  feat(cli): remove cobra cli support (kubernetes-sigs#6034)
  fix(chart): ptsc indentation (kubernetes-sigs#6054)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#6051)
  feat(aws): enable support for NAPTR records (kubernetes-sigs#6022)
  refactor: extract normalizeDNSName to idna package for reuse (kubernetes-sigs#6043)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

@ivankatliarchuk ivankatliarchuk Awaiting requested review from ivankatliarchuk

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@ivankatliarchuk ivankatliarchuk

@mloiseleur mloiseleur

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. internal Issues or PRs related to internal code lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. plan Issues or PRs related to external-dns plan size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@u-kai @k8s-ci-robot @ivankatliarchuk @coveralls @mloiseleur