-
Notifications
You must be signed in to change notification settings - Fork 632
Fix AttachedRoutes documentation aligned to count only Accepted Routes #4341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix AttachedRoutes documentation aligned to count only Accepted Routes #4341
Conversation
Signed-off-by: Davide Salerno <[email protected]>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidesalerno The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @davidesalerno! |
|
Hi @davidesalerno. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
one missing piece on the docs we have recently changed /ok-to-test |
robscott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidesalerno!
| // for Listeners with condition Accepted: false but MUST count successfully | ||
| // only attached Routes that may themselves have Accepted: true conditions. | ||
| // Attached Routes whose Accepted condition is False or Unknown (or that | ||
| // do not have an Accepted condition set) MUST NOT be included in this count. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been following this as closely as I should, but maybe I can reword this to make sure I'm understanding it correctly:
AttachedRoutesshould always be set on each Listener, even if the Listener itself has not been acceptedAttachedRoutesshould only represent the number of Routes with theAcceptedcondition set toTruethat have been attached to this Listener
If so, I'm completely on board with point 2, but confused by point 1 (although I recognize that it's not new in this PR).
/cc @rikatz @youngnick
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is fixing the documentation for the AttachedRoutes field specifying that counts only Accepted = true Routes
Which issue(s) this PR fixes:
Fixes #4321
Does this PR introduce a user-facing change?:
NONE