-
Notifications
You must be signed in to change notification settings - Fork 635
Fix AttachedRoutes documentation aligned to count only Accepted Routes #4341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been following this as closely as I should, but maybe I can reword this to make sure I'm understanding it correctly:
AttachedRoutesshould always be set on each Listener, even if the Listener itself has not been acceptedAttachedRoutesshould only represent the number of Routes with theAcceptedcondition set toTruethat have been attached to this ListenerIf so, I'm completely on board with point 2, but confused by point 1 (although I recognize that it's not new in this PR).
/cc @rikatz @youngnick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robscott Exactly, I changed only point 2 since it is what the issue is requesting, instead for point 1 I can confirm that based on the doc it seems to work in this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey Rob, so long story short, during the update of ListenerSet GEP (https://github.com/kubernetes-sigs/gateway-api/pull/4286/files) Nick questioned why we were counting Listeners not accepted as well, and well, me and @davidjumani copied the text from here.
In fact, the implementations today count just the accepted ones, but the text on the API description was wrong, so we are now "fixing it" and making it clear that AttachedRoutes MUST count just accepted routes.
Maybe @youngnick has some better wording here tho :)