Skip to content

Conversation

@davidjumani
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates the API to reflect the GEP changes introduced in #4286

Does this PR introduce a user-facing change?:

Update the Gateway status to include `AttachedListenerSets` - the count of ListenerSets that have successfully attached to the gateway

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 16, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidjumani
Once this PR has been reviewed and has the lgtm label, please assign shaneutt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2025
@davidjumani
Copy link
Contributor Author

davidjumani commented Dec 16, 2025

Unrelated to this PR, but should gateway.spec.AllowedListeners be updated to AllowedListenerSets for consistency?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2025
Comment on lines -1337 to -1366
const (
// AttachedListenerSets is a condition that is true when the Gateway has
// at least one ListenerSet attached to it.
//
// Possible reasons for this condition to be True are:
//
// * "ListenerSetsAttached"
//
// Possible reasons for this condition to be False are:
//
// * "NoListenerSetsAttached"
// * "ListenerSetsNotAllowed"
//
// Controllers may raise this condition with other reasons,
// but should prefer to use the reasons listed above to improve
// interoperability.
GatewayConditionAttachedListenerSets GatewayConditionType = "AttachedListenerSets"

// This reason is used with the "AttachedListenerSets" condition when the
// Gateway has at least one ListenerSet attached to it.
GatewayReasonListenerSetsAttached GatewayConditionReason = "ListenerSetsAttached"

// This reason is used with the "AttachedListenerSets" condition when the
// Gateway has no ListenerSets attached to it.
GatewayReasonNoListenerSetsAttached GatewayConditionReason = "NoListenerSetsAttached"

// This reason is used with the "AttachedListenerSets" condition when the
// Gateway has ListenerSets attached to it, but the ListenerSets are not allowed.
GatewayReasonListenerSetsNotAllowed GatewayConditionReason = "ListenerSetsNotAllowed"
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this based on the discussion during the community meeting on Dec 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants