-
Notifications
You must be signed in to change notification settings - Fork 635
api: Update Gateway status to reflect changes to GEP-1713 #4358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
api: Update Gateway status to reflect changes to GEP-1713 #4358
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidjumani The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Unrelated to this PR, but should |
427caf1 to
7f62e6e
Compare
| const ( | ||
| // AttachedListenerSets is a condition that is true when the Gateway has | ||
| // at least one ListenerSet attached to it. | ||
| // | ||
| // Possible reasons for this condition to be True are: | ||
| // | ||
| // * "ListenerSetsAttached" | ||
| // | ||
| // Possible reasons for this condition to be False are: | ||
| // | ||
| // * "NoListenerSetsAttached" | ||
| // * "ListenerSetsNotAllowed" | ||
| // | ||
| // Controllers may raise this condition with other reasons, | ||
| // but should prefer to use the reasons listed above to improve | ||
| // interoperability. | ||
| GatewayConditionAttachedListenerSets GatewayConditionType = "AttachedListenerSets" | ||
|
|
||
| // This reason is used with the "AttachedListenerSets" condition when the | ||
| // Gateway has at least one ListenerSet attached to it. | ||
| GatewayReasonListenerSetsAttached GatewayConditionReason = "ListenerSetsAttached" | ||
|
|
||
| // This reason is used with the "AttachedListenerSets" condition when the | ||
| // Gateway has no ListenerSets attached to it. | ||
| GatewayReasonNoListenerSetsAttached GatewayConditionReason = "NoListenerSetsAttached" | ||
|
|
||
| // This reason is used with the "AttachedListenerSets" condition when the | ||
| // Gateway has ListenerSets attached to it, but the ListenerSets are not allowed. | ||
| GatewayReasonListenerSetsNotAllowed GatewayConditionReason = "ListenerSetsNotAllowed" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this based on the discussion during the community meeting on Dec 2
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates the API to reflect the GEP changes introduced in #4286
Does this PR introduce a user-facing change?: