Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 4 additions & 36 deletions apis/v1/gateway_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -1009,19 +1009,18 @@ type GatewayStatus struct {
// +kubebuilder:validation:MaxItems=64
Listeners []ListenerStatus `json:"listeners,omitempty"`

// AttachedListeners represents the total number of ListenerSets that have been
// AttachedListenerSets represents the total number of ListenerSets that have been
// successfully attached to this Gateway.
//
// A ListenerSet is successfully attached to a Gateway
// when all the following conditions are met :
// A ListenerSet is successfully attached to a Gateway when all the following conditions are met:
// - The ListenerSet is selected by the Gateway's AllowedListeners field
// - The ListenerSet has a valid ParentRef selecting the Gateway
// - The ListenerSet's status has the condition "Accepted: true"
//
// Uses for this field include troubleshooting AttachedListeners attachment and
// Uses for this field include troubleshooting AttachedListenerSets attachment and
// measuring blast radius/impact of changes to a Gateway.
// +optional
AttachedListeners *int32 `json:"attachedListeners,omitempty"`
AttachedListenerSets *int32 `json:"attachedListenerSets,omitempty"`
}

// GatewayInfrastructure defines infrastructure level attributes about a Gateway instance.
Expand Down Expand Up @@ -1334,37 +1333,6 @@ const (
GatewayReasonListenersNotReady GatewayConditionReason = "ListenersNotReady"
)

const (
// AttachedListenerSets is a condition that is true when the Gateway has
// at least one ListenerSet attached to it.
//
// Possible reasons for this condition to be True are:
//
// * "ListenerSetsAttached"
//
// Possible reasons for this condition to be False are:
//
// * "NoListenerSetsAttached"
// * "ListenerSetsNotAllowed"
//
// Controllers may raise this condition with other reasons,
// but should prefer to use the reasons listed above to improve
// interoperability.
GatewayConditionAttachedListenerSets GatewayConditionType = "AttachedListenerSets"

// This reason is used with the "AttachedListenerSets" condition when the
// Gateway has at least one ListenerSet attached to it.
GatewayReasonListenerSetsAttached GatewayConditionReason = "ListenerSetsAttached"

// This reason is used with the "AttachedListenerSets" condition when the
// Gateway has no ListenerSets attached to it.
GatewayReasonNoListenerSetsAttached GatewayConditionReason = "NoListenerSetsAttached"

// This reason is used with the "AttachedListenerSets" condition when the
// Gateway has ListenerSets attached to it, but the ListenerSets are not allowed.
GatewayReasonListenerSetsNotAllowed GatewayConditionReason = "ListenerSetsNotAllowed"
)
Comment on lines -1337 to -1366
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this based on the discussion during the community meeting on Dec 2


// ListenerStatus is the status associated with a Listener.
type ListenerStatus struct {
// Name is the name of the Listener that this status corresponds to.
Expand Down
4 changes: 2 additions & 2 deletions apis/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions apisx/v1alpha1/xlistenerset_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,12 @@ import (
// - A ListenerSet can reference secrets/backends in its own namespace without a ReferenceGrant
//
// Gateway Integration:
// - The parent Gateway's status will include an "AttachedListenerSets" condition
// - This condition will be:
// - True: when AllowedListeners is set and at least one child ListenerSet is attached
// - False: when AllowedListeners is set but no valid listeners are attached, or when AllowedListeners is not set or false
// - Unknown: when no AllowedListeners config is present
// - The parent Gateway's status will include "AttachedListenerSets"
// which is the count of ListenerSets that have successfully attached to a Gateway
// A ListenerSet is successfully attached to a Gateway when all the following conditions are met:
// - The ListenerSet is selected by the Gateway's AllowedListeners field
// - The ListenerSet has a valid ParentRef selecting the Gateway
// - The ListenerSet's status has the condition "Accepted: true"
type XListenerSet struct {
metav1.TypeMeta `json:",inline"`
// +optional
Expand Down
16 changes: 8 additions & 8 deletions applyconfiguration/apis/v1/gatewaystatus.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion applyconfiguration/internal/internal.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 8 additions & 10 deletions config/crd/experimental/gateway.networking.k8s.io_gateways.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 8 additions & 10 deletions config/crd/standard/gateway.networking.k8s.io_gateways.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions pkg/generated/openapi/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.