-
Notifications
You must be signed in to change notification settings - Fork 335
frontend: PluginSettings: Refactor local storage and plugin data #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
frontend: PluginSettings: Refactor local storage and plugin data #3123
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vyncent-t The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
de2cb34
to
9c04cce
Compare
c1fb342
to
e995299
Compare
7e6f2f5
to
d23b279
Compare
e2e tests are passing, none of the log changes cause it to fail. going to drop e2e test changes here and rebase when #3144 is merged |
1adc26f
to
52bc764
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm against moving the logic around into more places. It makes it more difficult to hunt for things.
Additionally, there are a bunch of separate changes all together in one commit.
52bc764
to
9b5e04a
Compare
I have another PR that requires these changes so that the plugin info is compatible with plugins settings headlamp-k8s/plugins#117 |
9b5e04a
to
f432e02
Compare
f432e02
to
945c9c9
Compare
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
Signed-off-by: Vincent T <[email protected]>
945c9c9
to
a624f0a
Compare
original - #2671
Fixes Issue #2595
Description
name
andisEnabled
status in local storage. This ensures plugin settings persist when closing and reopening the app.usePlugins
hook intolib/k8s/api/v2
Changes
name
andisEnabled
) in local storage.How to Test
headlampPluginSettings
headlampPluginSettings
name
andisEnabled
) are fetched from the backend and displayed correctly in the UI.Notes