Fix e2e auth logic + add namespace a11y playwright tests #3144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vyncent-t The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
vyncent-t
force-pushed
the
namespace-a11y-playwright-test
branch
from
cb5bcc1 to
3972d6b
Compare
k8s-ci-robot
added
size/M
vyncent-t
force-pushed
the
namespace-a11y-playwright-test
branch
2 times, most recently
from
96d736c to
f3a977d
Compare
k8s-ci-robot
added
size/S
vyncent-t
force-pushed
the
namespace-a11y-playwright-test
branch
from
f3a977d to
7303bd1
Compare
k8s-ci-robot
added
size/M
vyncent-t
force-pushed
the
namespace-a11y-playwright-test
branch
from
7303bd1 to
89d528a
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
illume
reviewed
Apr 23, 2025
| @@ -36,6 +36,7 @@ export function CreateResourceButton(props: CreateResourceButtonProps) { | |||
| errorMessage={errorMessage} | |||
| onEditorChanged={() => setErrorMessage('')} | |||
| title={t('translation|Create {{ name }}', { name })} | |||
| aria-label={t('translation|Create resource button')} | |||
There was a problem hiding this comment.
- This should be fixed inside EditorDialog to use the title. Because EditorDialog is used in a number of other places, and it has different states to consider where the label should go.
- Using the same name as the title would be better, because it's more correct and we already have translations for it.
illume
requested changes
Apr 23, 2025
vyncent-t
force-pushed
the
namespace-a11y-playwright-test
branch
from
89d528a to
93e7825
Compare
…e button Signed-off-by: Vincent T <[email protected]>
since we now use a multi cluster structure to run our tests, the cluster navigation step must be its own full nav step, different from navigateToPage, if it is tied to an auth step. Signed-off-by: Vincent T <[email protected]>
vyncent-t
force-pushed
the
namespace-a11y-playwright-test
branch
from
93e7825 to
0161e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves accessibility testing coverage and reliability of Playwright E2E tests in the project.
Note: this also fixes some e2e test failures for my other branches, once this is merged in I will drop the duplicates in the other branches.
Accessibility Enhancements
@axe-core/playwrightintegration to the Namespaces Playwright test to perform automated A11Y checks.aria-labelto ensure compliance with screen reader standards.Navigation & Auth Logic Improvements
(Previously, navigation during multi-cluster testing was unreliable and prone to hanging or timing out due to race conditions and cluster token loading delays.)
Notes