Skip to content

Conversation

@Pratik-050
Copy link
Contributor

Note for reviewers:

Bengali language support has been added to the Headlamp website to make it easier for native Bengali users to navigate and interact with the site.

Resolves: #3270

Screenshot from 2025-05-18 12-07-59

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 18, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested review from illume and sniok May 18, 2025 06:43
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pratik-050
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @Pratik-050!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 18, 2025
@illume
Copy link
Contributor

illume commented May 18, 2025

Amazing. Thank you.

For Kubernetes jargon like Pods, kubectl and Kubernetes there's usually not a good word to translate it to. So we tend to keep them in English unless there's a well known word for it in the language.

We follow a linux kernel style of commit messages. With the context at the front followed by an action word and the rest.
Would you mind changing them to something like this?

frontend: app: i18n: Add Bengali language

@illume illume added frontend Issues related to the frontend a11y Accessibility related issues app i18n labels May 18, 2025
@Pratik-050 Pratik-050 changed the title feat:Add Bengali language feat: app: i18n: Add Bengali language May 18, 2025
@Pratik-050 Pratik-050 changed the title feat: app: i18n: Add Bengali language frontend: app: i18n: Add Bengali language May 18, 2025
@Pratik-050
Copy link
Contributor Author

Pratik-050 commented May 18, 2025

Hello @illume thanks for your feedback!
I've translated the technical terms back to English (like: Kubernetes, Pods, Replicas, etc.). I'm native Bengali myself so I made sure that the translations looks good.
I've changed the commit message as well.
Will look forward for any further comments!

@illume
Copy link
Contributor

illume commented May 19, 2025

Thanks @Pratik-050

Now we need to find someone else who knows Bengali to review it.

@ChayanDass
Copy link
Contributor

I'm also a native Bengali speaker and happy to help with the review.

Just a quick question — is it necessary to include Bengali (or other regional languages) in Headlamp? Since the tool is mostly used by technically proficient users, many of whom are already comfortable with English, I’m wondering if localization is a priority here.

@illume
Copy link
Contributor

illume commented May 19, 2025

Hi @ChayanDass thanks for your offer to review. Much appreciated!

Any localization work done to make Headlamp and Kubernetes more accessible and comfy is welcome.

@Pratik-050
Copy link
Contributor Author

Thanks @ChayanDass! Please have a look into the PR when you're free.
Speaking of the regional languages, it's true that most of the professionals are proficient with English but some may find it more comfortable to experience the tool in their native language. You can find most of the tools in various regional languages. It's about making the tool more comfortable and accessible in the end.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2025
@ChayanDass
Copy link
Contributor

@illume everything looks good , but I think some words are better without translation it's a suggestion .

@illume
Copy link
Contributor

illume commented May 20, 2025

Thanks @ChayanDass

Yeah, if there’s any words you think are better without a translation please let us know?

Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder to rebase the branch against main when you get the chance to keep things up to date 😄

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2025
@Pratik-050
Copy link
Contributor Author

Just a reminder to rebase the branch against main when you get the chance to keep things up to date 😄

Yes sorry I've missed the conflicts, resolved them now.
@ChayanDass can you suggest which words are better without a translation then I can change them. Thanks!

@illume
Copy link
Contributor

illume commented May 26, 2025

Thanks @ChayanDass

@Pratik-050
Copy link
Contributor Author

Thanks! @ChayanDass I've resolved all your comments and also changed some translations that came to my sight please have a look again and let me know if you can find something else.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2025
@illume
Copy link
Contributor

illume commented Oct 2, 2025

@ChayanDass would you mind checking the last set of changes made?

@illume illume marked this pull request as draft October 2, 2025 13:49
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
@ChayanDass
Copy link
Contributor

ChayanDass commented Oct 4, 2025

Yeah , Sure I will verify the changes by Tommorow..

@ChayanDass
Copy link
Contributor

@illume, I have checked the changes, and it looks good to me ..

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility related issues app cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. frontend Issues related to the frontend i18n lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

Add Bengali language

6 participants