Skip to content

Templates: Secret: Added meUserInfoURL to secrets#4379

Merged
illume merged 1 commit intokubernetes-sigs:mainfrom
mudit06mah:meUserInfoURL
Feb 1, 2026
Merged

Templates: Secret: Added meUserInfoURL to secrets#4379
illume merged 1 commit intokubernetes-sigs:mainfrom
mudit06mah:meUserInfoURL

Conversation

@mudit06mah
Copy link
Contributor

@mudit06mah mudit06mah commented Jan 18, 2026

Summary

Added meUserInfoURL to secrets

Related Issue

Fixes #4363

Changes

Added:

{{- with .meUserInfoURL }}
  meUserInfoURL: {{ . | b64enc | quote }}

to secrets.yaml

Steps to Test

Run:

helm template headlamp-test ./charts/headlamp   --set config.oidc.createSecret=true   --set config.oidc.meUserInfoURL="https://example.com/userinfo"   --show-only templates/secret.yaml

Output:

# Source: headlamp/templates/secret.yaml
apiVersion: v1
kind: Secret
metadata:
  name: oidc
  namespace: default
type: Opaque
data:
  meUserInfoURL: "aHR0cHM6Ly9leGFtcGxlLmNvbS91c2VyaW5mbw=="

(Succesful)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2026
@k8s-ci-robot k8s-ci-robot requested review from sniok and yolossn January 18, 2026 05:05
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2026
@illume illume requested a review from Copilot January 18, 2026 11:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the OIDC configuration support by adding the meUserInfoURL field to the Kubernetes secret template. The field was already documented in values.yaml and used in the deployment template, but was missing from the secret generation, preventing users from storing this sensitive URL in a Kubernetes secret.

Changes:

  • Added meUserInfoURL to the secret.yaml template with base64 encoding, following the existing pattern for other OIDC string fields

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mudit06mah
Copy link
Contributor Author

mudit06mah commented Jan 18, 2026

The linting error actually arises because of the fix, meUserInfoUrl was missing earlier.
Should I change the failing snapshots as well?

@skoeva
Copy link
Contributor

skoeva commented Jan 19, 2026

see #4380 (review)

@mudit06mah
Copy link
Contributor Author

mudit06mah commented Jan 19, 2026

@skoeva I have updated all snapshots, this branch is ready to be merged.

@mudit06mah mudit06mah changed the title Added meUserInfoURL to secrets Templates: Secret: Added meUserInfoURL to secrets Jan 21, 2026
@mudit06mah
Copy link
Contributor Author

This PR passes all tests and is ready to be merged.

@mudit06mah
Copy link
Contributor Author

@sniok @yolossn Please review this PR.

@mudit06mah
Copy link
Contributor Author

@sniok @yolossn Can you Please review this PR?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked in the issue if the fix that they are expected.

Can you please document this to the README.md and the values file?

@mudit06mah
Copy link
Contributor Author

@illume I have Updated README.md, Can you please review it and tell me if you can find other places to add it? :)

Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, mudit06mah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2026
@illume illume merged commit fd4d771 into kubernetes-sigs:main Feb 1, 2026
3 of 4 checks passed
@illume illume added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 1, 2026
@illume illume added the charts label Feb 1, 2026
@illume illume added this to the v0.40.0 milestone Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

meUserInfoURL with create.secret=true failure

4 participants