Templates: Secret: Added meUserInfoURL to secrets#4379
Templates: Secret: Added meUserInfoURL to secrets#4379illume merged 1 commit intokubernetes-sigs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR completes the OIDC configuration support by adding the meUserInfoURL field to the Kubernetes secret template. The field was already documented in values.yaml and used in the deployment template, but was missing from the secret generation, preventing users from storing this sensitive URL in a Kubernetes secret.
Changes:
- Added
meUserInfoURLto the secret.yaml template with base64 encoding, following the existing pattern for other OIDC string fields
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The linting error actually arises because of the fix, |
|
see #4380 (review) |
|
@skoeva I have updated all snapshots, this branch is ready to be merged. |
67eb888 to
e6fae64
Compare
|
This PR passes all tests and is ready to be merged. |
e6fae64 to
9607df1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
illume
left a comment
There was a problem hiding this comment.
I asked in the issue if the fix that they are expected.
Can you please document this to the README.md and the values file?
9607df1 to
8a42327
Compare
|
@illume I have Updated README.md, Can you please review it and tell me if you can find other places to add it? :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume, mudit06mah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Added meUserInfoURL to secrets
Related Issue
Fixes #4363
Changes
Added:
to secrets.yaml
Steps to Test
Run:
Output:
(Succesful)