Templates: Deployment: Fixed Deployment.yaml

[mudit06mah]

Summary:

Fixes deployment to add quotes to useAccessToken and PKCE

Related Issue:

Fixes #4364

• incorrect env for deployment with create.secret false for token #4364

Changes:

• Added {{ | quote }} to OIDC_USE_ACCESS_TOKEN and OIDC_USE_PKCE.
• Error arises as value is taken to be a boolean (true) while it should be taken as a string ("true").

Steps to Test:

Run:

helm upgrade --install headlamp-test ./charts/headlamp \
  --namespace kube-system \
  --set config.oidc.useAccessToken=true \
  --set config.oidc.secret.create=false

Inside root folder of headlamp
After that Run:

kubectl get deployment headlamp-test -n kube-system -o yaml | grep OIDC_USE_ACCESS_TOKEN -A 1

Runs Successfully (output):

        - -oidc-use-access-token=$(OIDC_USE_ACCESS_TOKEN)
        env:
        - name: OIDC_USE_ACCESS_TOKEN
          value: "true"

Note: Accidentally closed my previous PR on the same issue, hence creating a new one fixing the issue

[Copilot]

Pull request overview

This PR fixes a Helm templating issue where boolean values for OIDC configuration were not being properly quoted as strings in the deployment manifest. The fix adds the quote filter to ensure environment variables receive string values instead of unquoted boolean values, which would cause YAML parsing issues.

Changes:

• Added | quote filter to OIDC_USE_ACCESS_TOKEN environment variable
• Added | quote filter to OIDC_USE_PKCE environment variable

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mudit06mah]

Linting error arises due to the fix, I apologize for not running these tests earlier.
Should I change them as well?

[skoeva]

there's a command in the CI output to update the templates, you could run that to fix the error

[mudit06mah]

I have updated all snapshots, this branch is ready to be merged.

[skoeva]

See #4402 (review)

[mudit06mah]

This PR passes all tests and is ready to be merged.

[mudit06mah]

@skoeva Can you please review this again? :)

[illume]

@mudit06mah please check the test failure, and run the test locally?

[mudit06mah]

@illume Really Sorry for the overlook from my side! I have changed the tests accordingly and this PR passes all tests now. Really sorry for earlier 🙇

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[illume]

🎉 thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, mudit06mah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [illume]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment