Frontend: Pod: Added Deeplink compatibility for viewing logs#4399
Frontend: Pod: Added Deeplink compatibility for viewing logs#4399illume merged 1 commit intokubernetes-sigs:mainfrom
Conversation
38e6073 to
ba6696f
Compare
|
This PR passes all tests and is ready to be merged. |
|
@sniok It appears I was unaware of i18n translation. This PR should pass without any errors now :) |
ba6696f to
50c88f5
Compare
There was a problem hiding this comment.
Pull request overview
Adds support for deep-linking directly into a Pod’s logs view via ?view=logs, so opening a pod details URL with that query param automatically launches the logs activity.
Changes:
- Parse the
viewquery parameter inPodDetailsand auto-launch logs whenview=logs. - Refactor the “Show Logs” action handler to reuse a shared
launchLogshelper. - Normalize/move the
Logsi18n glossary key placement across multiple locales.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/pod/Details.tsx | Adds view=logs query-param handling and refactors log-launching into a helper used by both the button and deep link. |
| frontend/src/i18n/locales/en/glossary.json | Moves/ensures the Logs key exists in the expected position. |
| frontend/src/i18n/locales/de/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/es/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/fr/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/hi/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/it/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/ja/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/ko/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/pt/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/ta/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/zh/glossary.json | Moves the Logs key entry for consistency. |
| frontend/src/i18n/locales/zh-tw/glossary.json | Moves the Logs key entry for consistency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
50c88f5 to
9b86833
Compare
|
@illume I have made the changes suggested by copilot. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
illume
left a comment
There was a problem hiding this comment.
Looking good. Thanks for those changes 🎉
Can you please answer the two questions I left? After you update the testing scenarios in the PR description I will manually test it.
9b86833 to
fa1b324
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks @ranjit-parva for the review/testing. |
fa1b324 to
dc7e7e4
Compare
|
@illume Made all changes suggested by copilot, Please review this again 👾 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume, mudit06mah, ranjit-parva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |

Summary
This PR let's users to add
?view=logsto the URL to get logs for a pod.Related Issue
Fixes #4348
Changes
Changed Details.tsx to check for query params, if found it activates log window.
Steps to Test
Through Deeplink:
/c/{cluster}/pods/{namespace}/{pod-name}?view=logs, it opens up the logs for that particular pod.From client Side:
window.history.pushState({}, '', window.location.pathname + '?view=logs');window.dispatchEvent(new PopStateEvent('popstate'));Screenshots (if applicable)