Skip to content

docs: add reason-aware repair policy matching RFC - #3263

Open
sebpalmerio wants to merge 1 commit into
kubernetes-sigs:mainfrom
sebpalmerio:reason-aware-repair-policy-matching-rfc
Open

docs: add reason-aware repair policy matching RFC#3263
sebpalmerio wants to merge 1 commit into
kubernetes-sigs:mainfrom
sebpalmerio:reason-aware-repair-policy-matching-rfc

Conversation

@sebpalmerio

Copy link
Copy Markdown

Description

This PR adds a design RFC (designs/reason-aware-repair-policy-matching.md) defining reason-aware repair policy matching and eligibility for Karpenter Node Repair.

Problem

Node Repair currently maps a NodeCondition type and status to one toleration before replacing the Node. The reboot proposal adds another repair action, so diagnoses reported under the same condition may require different confidence delays, drain limits, and responses. Provider rules may also overlap and become eligible at different times. Matching must resolve those rules deterministically without relying on policy order or in-memory state.

Proposal

Extend the provider-supplied RepairPolicy with ReasonRegex and Action, then:

  • Match stable NodeCondition.reason values with Go regular expressions.
  • Require a condition-level replacement fallback for compatibility with newly introduced reasons.
  • Evaluate overlapping policies independently and merge eligible behavior using fixed action, termination grace period, and eligibility rules.
  • Derive eligibility from lastTransitionTime and reconstruct it from current API state after restart.
  • Validate the complete provider policy set before registering Node Repair.

Related RFCs

How was this change tested?

N/A — documentation/design only.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LLMs were used in the writing of this document, but the contribution is mine.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 26, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: sebpalmerio / name: Sebestien Palmerio (ea18c54)

@kubernetes-prow

Copy link
Copy Markdown

Welcome @sebpalmerio!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 26, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebpalmerio
Once this PR has been reviewed and has the lgtm label, please assign njtran for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant