You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a design RFC (designs/reason-aware-repair-policy-matching.md) defining reason-aware repair policy matching and eligibility for Karpenter Node Repair.
Problem
Node Repair currently maps a NodeCondition type and status to one toleration before replacing the Node. The reboot proposal adds another repair action, so diagnoses reported under the same condition may require different confidence delays, drain limits, and responses. Provider rules may also overlap and become eligible at different times. Matching must resolve those rules deterministically without relying on policy order or in-memory state.
Proposal
Extend the provider-supplied RepairPolicy with ReasonRegex and Action, then:
Match stable NodeCondition.reason values with Go regular expressions.
Require a condition-level replacement fallback for compatibility with newly introduced reasons.
Evaluate overlapping policies independently and merge eligible behavior using fixed action, termination grace period, and eligibility rules.
Derive eligibility from lastTransitionTime and reconstruct it from current API state after restart.
Validate the complete provider policy set before registering Node Repair.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
This pull-request has been approved by: sebpalmerio Once this PR has been reviewed and has the lgtm label, please assign njtran for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
kubernetes-prowBot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
and removed
cncf-cla: no
Indicates the PR's author has not signed the CNCF CLA.
labels
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.size/LDenotes a PR that changes 100-499 lines, ignoring generated files.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a design RFC (
designs/reason-aware-repair-policy-matching.md) defining reason-aware repair policy matching and eligibility for Karpenter Node Repair.Problem
Node Repair currently maps a
NodeConditiontype and status to one toleration before replacing the Node. The reboot proposal adds another repair action, so diagnoses reported under the same condition may require different confidence delays, drain limits, and responses. Provider rules may also overlap and become eligible at different times. Matching must resolve those rules deterministically without relying on policy order or in-memory state.Proposal
Extend the provider-supplied
RepairPolicywithReasonRegexandAction, then:NodeCondition.reasonvalues with Go regular expressions.lastTransitionTimeand reconstruct it from current API state after restart.Related RFCs
How was this change tested?
N/A — documentation/design only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
LLMs were used in the writing of this document, but the contribution is mine.