Be more clear on the expected format of --wait option #3419

radeksm · 2023-11-13T07:18:33Z

This is just a very minor follow up on this pull request 3418.

kind create cluster --help does not explain what is expected format of --wait option. This is documented well in site/content/docs/user/quick-start.md but this simple change to command line help is going to save some time and confusion.

k8s-ci-robot · 2023-11-13T07:18:43Z

Hi @radeksm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

neolit123

/lgtm

neolit123 · 2023-11-13T07:22:49Z

/ok-to-test

radeksm · 2023-11-13T13:38:29Z

/test pull-kind-e2e-kubernetes-1-24

stmcginnis · 2023-11-13T13:56:29Z

/lgtm

BenTheElder · 2023-11-13T17:29:59Z

FWIW, this problem exists in kubectl as well, e.g. kubectl wait --help --timeout docs, these are go https://pkg.go.dev/time#Duration if we want to be more specific.

This change seems fine, but I prefer to align with kubectl where possible on the CLI flags and behaviors for consistency, maybe we need (or have already and can just reference?) a kubernetes.io docs page to cover these duration strings, they're used in other places in the project.

radeksm · 2023-11-14T15:12:04Z

FWIW, this problem exists in kubectl as well, e.g. kubectl wait --help --timeout docs, these are go https://pkg.go.dev/time#Duration if we want to be more specific.

This change seems fine, but I prefer to align with kubectl where possible on the CLI flags and behaviors for consistency, maybe we need (or have already and can just reference?) a kubernetes.io docs page to cover these duration strings, they're used in other places in the project.

@BenTheElder I will create new pull req to adjust in for kubectl so we can make it more clear and consistent.

Actually the same kind of inconsistency exists in kubectl on blow three subcommands too:

kubectl drain --timeout=...
kubectl wait  --timeout=...
kubectl delete  --timeout=...

radeksm · 2023-11-14T15:29:16Z

/test pull-kind-e2e-kubernetes-1-24
/test pull-kind-e2e-kubernetes-1-25

k8s-ci-robot · 2023-11-14T15:55:58Z

New changes are detected. LGTM label has been removed.

radeksm · 2023-11-15T05:02:17Z

/retest

radeksm · 2023-11-15T08:06:58Z

/test pull-kind-e2e-kubernetes-1-24

radeksm · 2023-11-15T12:39:35Z

/test pull-kind-e2e-kubernetes-1-24

radeksm · 2023-11-16T06:53:42Z

/test pull-kind-e2e-kubernetes-1-24

radeksm · 2023-11-16T07:50:46Z

/test pull-kind-e2e-kubernetes-1-24

aojea · 2023-11-16T07:56:54Z

1.24 seems to be permanently failing https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=kind&pr=3419, keep retesting is not going to solve the problem ;)

radeksm · 2023-11-16T08:34:48Z

1.24 seems to be permanently failing https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=kind&pr=3419, keep retesting is not going to solve the problem ;)

Yeahhh but it seems to be not related to my change and I thought it's some CI problem with lack of resources. It was the same with pull-kind-e2e-kubernetes-1-25 which eventually passed.
Sorry but I am not familiar with the CI.

BenTheElder

... we (=kind approvers) really should've gotten back to this PR a very long time ago, apologies, I have mostly been chasing bug fixes and debugging when I have time, I'm aiming to make sure we keep up with the PR backlog going forward.

I have one minor correction request, if you're not available after some time given the duration we can apply it in a follow-up so as to retain the attribution for this commit.

pkg/cmd/kind/create/cluster/createcluster.go

linux-foundation-easycla · 2025-02-12T19:34:51Z

✅ login: radeksm / name: Radoslaw Śmigielski (3e0af2e)
✅ login: BenTheElder / name: Benjamin Elder (a57f5e9)
❌ The email address for the commit (56db128) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

k8s-ci-robot · 2025-02-12T19:34:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radeksm
Once this PR has been reviewed and has the lgtm label, please ask for approval from aojea. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2025-02-12T19:36:46Z

... So the github "commit suggestion" button broke the CLA :/

BenTheElder · 2025-02-12T19:41:06Z

The email address for the commit (56db128) is not linked to the GitHub account, preventing the EasyCLA check.

... ah, this is because of the existing commit, I think due to @radeksm changing account info since this PR was started and then neglected on our end (sorry!)

stmcginnis

Sorry this has sat for so long. @radeksm would you be able to update to fix the CLA issues now? If so, we should be able to get this through much faster than it's been.

stmcginnis · 2025-04-07T06:27:06Z

pkg/cmd/kind/create/cluster/createcluster.go

 		"wait",
 		time.Duration(0),
-		"wait for control plane node to be ready (default 0s)",
+		"the length of time to wait for control plane node to be ready (default 0s). Non-zero values should contain a corresponding time unit (e.g. 1s, 2m, 3h). A value of zero means don't wait.",


Now that this is two full sentences, it would be nice if it started with capitalization.

@stmcginnis maybe at this point send an updated PR, I feel bad for how this went but we also can't merge CLA failures and you're suggesting changes anyhow (and the PR is single line ...)

k8s-ci-robot · 2025-04-30T06:54:02Z

@radeksm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kind-e2e-kubernetes-1-24	`56db128`	link	true	`/test pull-kind-e2e-kubernetes-1-24`
pull-kind-conformance-parallel-dual-stack-ipv4-ipv6	`3e0af2e`	link	true	`/test pull-kind-conformance-parallel-dual-stack-ipv4-ipv6`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

stmcginnis · 2025-04-30T14:23:11Z

/easycla

Follow up from kubernetes-sigs#3418 and kubernetes-sigs#3419. `kind create cluster --help` does not explain what is the expected format of the `--wait` option. This is described in the quick start, but not in the command line help output. This change adds more a more verbose description to make it more clear. Signed-off-by: Sean McGinnis <[email protected]>

stmcginnis · 2025-08-21T06:14:30Z

Redone with #3992

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2023

k8s-ci-robot requested review from aojea and neolit123 November 13, 2023 07:18

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2023

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2023

neolit123 reviewed Nov 13, 2023

View reviewed changes

k8s-ci-robot assigned neolit123 Nov 13, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2023

k8s-ci-robot assigned stmcginnis Nov 13, 2023

radeksm force-pushed the wait_option_format branch from b4aa08f to af6c9e8 Compare November 14, 2023 15:55

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023

Be more clear on the expected format of --wait option

56db128

radeksm force-pushed the wait_option_format branch from af6c9e8 to 56db128 Compare November 15, 2023 06:56

BenTheElder reviewed Jan 23, 2025

View reviewed changes

pkg/cmd/kind/create/cluster/createcluster.go Outdated Show resolved Hide resolved

BenTheElder assigned aojea and BenTheElder and unassigned neolit123 Jan 23, 2025

Update pkg/cmd/kind/create/cluster/createcluster.go

a57f5e9

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 12, 2025

stmcginnis reviewed Apr 7, 2025

View reviewed changes

Merge branch 'kubernetes-sigs:main' into wait_option_format

3e0af2e

stmcginnis mentioned this pull request Aug 21, 2025

Be more clear on the expected format of --wait option #3992

Open

stmcginnis closed this Aug 21, 2025

Be more clear on the expected format of --wait option #3419

Be more clear on the expected format of --wait option #3419

Uh oh!

Conversation

radeksm commented Nov 13, 2023

Uh oh!

k8s-ci-robot commented Nov 13, 2023

Uh oh!

neolit123 left a comment

Choose a reason for hiding this comment

Uh oh!

neolit123 commented Nov 13, 2023

Uh oh!

radeksm commented Nov 13, 2023

Uh oh!

stmcginnis commented Nov 13, 2023

Uh oh!

BenTheElder commented Nov 13, 2023

Uh oh!

radeksm commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

radeksm commented Nov 14, 2023

Uh oh!

k8s-ci-robot commented Nov 14, 2023

Uh oh!

radeksm commented Nov 15, 2023

Uh oh!

radeksm commented Nov 15, 2023

Uh oh!

radeksm commented Nov 15, 2023

Uh oh!

radeksm commented Nov 16, 2023

Uh oh!

radeksm commented Nov 16, 2023

Uh oh!

aojea commented Nov 16, 2023

Uh oh!

radeksm commented Nov 16, 2023

Uh oh!

BenTheElder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 12, 2025

Uh oh!

BenTheElder commented Feb 12, 2025

Uh oh!

BenTheElder commented Feb 12, 2025

Uh oh!

stmcginnis left a comment

Choose a reason for hiding this comment

Uh oh!

stmcginnis Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

BenTheElder Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 30, 2025

Uh oh!

stmcginnis commented Apr 30, 2025

Uh oh!

stmcginnis commented Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

radeksm commented Nov 14, 2023 •

edited

Loading

linux-foundation-easycla bot commented Feb 12, 2025 •

edited

Loading