Skip to content

Be more clear on the expected format of --wait option #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
radeksm wants to merge 3 commits into from
Closed

Be more clear on the expected format of --wait option #3419

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56db128
Be more clear on the expected format of --wait option
Nov 13, 2023
a57f5e9
Update pkg/cmd/kind/create/cluster/createcluster.go
BenTheElder Feb 12, 2025
3e0af2e
Merge branch 'kubernetes-sigs:main' into wait_option_format
radeksm Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/kind/create/cluster/createcluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
&flags.Wait,
"wait",
time.Duration(0),
"wait for control plane node to be ready (default 0s)",
"the length of time to wait for control plane node to be ready (default 0s). Non-zero values should contain a corresponding time unit (e.g. 1s, 2m, 3h). A value of zero means don't wait.",
Copy link
Contributor

@stmcginnis stmcginnis Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this is two full sentences, it would be nice if it started with capitalization.

Copy link
Member

@BenTheElder BenTheElder Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stmcginnis maybe at this point send an updated PR, I feel bad for how this went but we also can't merge CLA failures and you're suggesting changes anyhow (and the PR is single line ...)

)
cmd.Flags().StringVar(
&flags.Kubeconfig,
Expand Down
Loading