cli: align --name flag help and default #4070
Conversation
Standardize the --name/-n help text across commands and use cluster.DefaultName for create cluster so help output is consistent. Refs kubernetes-sigs#4044
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aliheydarabadii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @aliheydarabadii. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/S
| Short: "Creates a local Kubernetes cluster", | ||
| Long: "Creates a local Kubernetes cluster using Docker container 'nodes'", | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| cli.OverrideDefaultName(cmd.Flags()) |
There was a problem hiding this comment.
I think with this change there wouldn't be any need for the OverrideDefaultName function anymore.
There was a problem hiding this comment.
I think OverrideDefaultName is still necessary for KIND_CLUSTER_NAME support. It only runs when --name isn’t explicitly set, and the default change is just for consistent help output.
3 participants
Standardize the --name/-n help text across commands and use cluster.DefaultName for create cluster so help output is consistent. Refs #4044