Skip to content

cli: align --name flag help and default #4070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aliheydarabadii wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −9
Open

cli: align --name flag help and default #4070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/cmd/kind/create/cluster/createcluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
&flags.Name,
"name",
"n",
"",
"cluster name, overrides KIND_CLUSTER_NAME, config (default kind)",
cluster.DefaultName,
cli.NameFlagHelp,
)
cmd.Flags().StringVar(
&flags.Config,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/kind/delete/cluster/deletecluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Errors will only occur if the cluster resources exist and are not able to be del
"name",
"n",
cluster.DefaultName,
"the cluster name",
cli.NameFlagHelp,
)
cmd.Flags().StringVar(
&flags.Kubeconfig,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/kind/export/kubeconfig/kubeconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
"name",
"n",
cluster.DefaultName,
"the cluster context name",
cli.NameFlagHelp,
)
cmd.Flags().StringVar(
&flags.Kubeconfig,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/kind/export/logs/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
"name",
"n",
cluster.DefaultName,
"the cluster context name",
cli.NameFlagHelp,
)
return cmd
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/kind/get/kubeconfig/kubeconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
"name",
"n",
cluster.DefaultName,
"the cluster context name",
cli.NameFlagHelp,
)
cmd.Flags().BoolVar(
&flags.Internal,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/kind/get/nodes/nodes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
"name",
"n",
cluster.DefaultName,
"the cluster context name",
cli.NameFlagHelp,
)
cmd.Flags().BoolVarP(
&flags.AllClusters,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/kind/load/docker-image/docker-image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
"name",
"n",
cluster.DefaultName,
"the cluster context name",
cli.NameFlagHelp,
)
cmd.Flags().StringSliceVar(
&flags.Nodes,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/kind/load/image-archive/image-archive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
"name",
"n",
cluster.DefaultName,
"the cluster context name",
cli.NameFlagHelp,
)
cmd.Flags().StringSliceVar(
&flags.Nodes,
Expand Down
3 changes: 3 additions & 0 deletions pkg/internal/cli/override.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ import (
"github.com/spf13/pflag"
)

// NameFlagHelp is the shared help text for the --name flag.
const NameFlagHelp = "cluster name (or via KIND_CLUSTER_NAME)"

// OverrideDefaultName conditionally allows overriding the default cluster name
// by setting the KIND_CLUSTER_NAME environment variable
// only if --name wasn't set explicitly
Expand Down