-
Notifications
You must be signed in to change notification settings - Fork 481
Add custom Metrics tags for ClusterQueue #8099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add custom Metrics tags for ClusterQueue #8099
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ecdatadog The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @ecdatadog! |
|
Hi @ecdatadog. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Following the issue #7066, this PR proposes an implementation to inject some labels in kueue metrics (in this PR, it only shows the clusterQueue one but can be expected to other components such as localQueue) from k8s label/annotations.
It relies on :
There are different know issues of this PR :
Which issue(s) this PR fixes:
Fixes #7066
Special notes for your reviewer:
It is a draft PR that is only to discuss about what could be the implementation for #7066
Does this PR introduce a user-facing change?