Skip to content

Conversation

@kannon92
Copy link
Contributor

@kannon92 kannon92 commented Jan 8, 2026

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #8455

Special notes for your reviewer:

Does this PR introduce a user-facing change?

ACTION REQUIRED: The short name "wl" for workloads has been removed to avoid potential conflicts with the in-tree workload object coming into Kubernetes

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Jan 8, 2026
@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 72c5091
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/695fdea9620f2a0008fc557f

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2026
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove "wl" alias from kueuectl as well?

@kannon92 kannon92 force-pushed the deprecate-wl-short-name-2 branch from 5d99c04 to 7da8484 Compare January 8, 2026 16:01
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2026
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

/hold

for @mimowo 's confirmation.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 5e5ad1845fa964933b113f2699b40689c7b04e11

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2026
@mimowo
Copy link
Contributor

mimowo commented Jan 8, 2026

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/8472/pull-kueue-test-integration-extended-main/2009294407831916544
this failure looks related

@mimowo
Copy link
Contributor

mimowo commented Jan 8, 2026

/hold for @mimowo 's confirmation.

/unhold
LGTM, but we need to fix the failing test, probably left some place still using "wl"

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2026
@kannon92 kannon92 force-pushed the deprecate-wl-short-name-2 branch from 7da8484 to 72c5091 Compare January 8, 2026 16:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2026
@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y January 8, 2026 16:43
@tenzen-y
Copy link
Member

tenzen-y commented Jan 8, 2026

LGTM
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 4beabaa7306d52de2eab2cb45d591095697fc3b8

@k8s-ci-robot k8s-ci-robot merged commit cb67e5b into kubernetes-sigs:main Jan 8, 2026
28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.16 milestone Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate use of wl as short name for Kueue Workload

4 participants