-
Notifications
You must be signed in to change notification settings - Fork 4.3k
VPA: Introduce VPA feature gates, add InPlaceOrRecreate feature gate
#7932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 2 commits into
kubernetes:in-place-updates
from
maxcao13:feature-gates
Mar 21, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| Copyright 2025 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package features | ||
|
|
||
| import ( | ||
| "k8s.io/apimachinery/pkg/util/runtime" | ||
| "k8s.io/apimachinery/pkg/util/version" | ||
| "k8s.io/component-base/featuregate" | ||
|
|
||
| "k8s.io/autoscaler/vertical-pod-autoscaler/common" | ||
| ) | ||
|
|
||
| const ( | ||
| // Every feature gate should add method here following this template: | ||
| // | ||
| // // alpha: v1.X | ||
| // // components: admission-controller, recommender, updater | ||
maxcao13 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // | ||
| // MyFeature featuregate.Feature = "MyFeature". | ||
| // | ||
| // Feature gates should be listed in alphabetical, case-sensitive | ||
| // (upper before any lower case character) order. This reduces the risk | ||
| // of code conflicts because changes are more likely to be scattered | ||
| // across the file. | ||
| // | ||
| // In each feature gate description, you must specify "components". | ||
| // The feature must be enabled by the --feature-gates argument on each listed component. | ||
|
|
||
| // alpha: v1.4.0 | ||
| // components: admission-controller, updater | ||
|
|
||
| // InPlaceOrRecreate enables the InPlaceOrRecreate update mode to be used. | ||
| // Requires KEP-1287 InPlacePodVerticalScaling feature-gate to be enabled on the cluster. | ||
| InPlaceOrRecreate featuregate.Feature = "InPlaceOrRecreate" | ||
| ) | ||
|
|
||
| // MutableFeatureGate is a mutable, versioned, global FeatureGate. | ||
| var MutableFeatureGate featuregate.MutableVersionedFeatureGate = featuregate.NewFeatureGate() | ||
|
|
||
| // Enabled is a helper function for MutableFeatureGate.Enabled(f) | ||
| func Enabled(f featuregate.Feature) bool { | ||
| return MutableFeatureGate.Enabled(f) | ||
| } | ||
|
|
||
| func init() { | ||
| // set the emulation version to align with VPA versioning system | ||
| runtime.Must(MutableFeatureGate.SetEmulationVersion(version.MustParse(common.VerticalPodAutoscalerVersion()))) | ||
| runtime.Must(MutableFeatureGate.AddVersioned(defaultVersionedFeatureGates)) | ||
| } | ||
33 changes: 33 additions & 0 deletions
33
vertical-pod-autoscaler/pkg/features/versioned_features.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| Copyright 2025 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package features | ||
|
|
||
| import ( | ||
| "k8s.io/apimachinery/pkg/util/version" | ||
| "k8s.io/component-base/featuregate" | ||
| ) | ||
|
|
||
| // defaultVersionedFeatureGates consists of all known VPA-specific feature keys with VersionedSpecs. | ||
| // To add a new feature, define a key for it in pkg/features/features.go and add it here. The features will be | ||
| // available throughout Kubernetes binaries. | ||
|
|
||
| // Entries are alphabetized. | ||
| var defaultVersionedFeatureGates = map[featuregate.Feature]featuregate.VersionedSpecs{ | ||
| InPlaceOrRecreate: { | ||
| {Version: version.MustParse("1.4.0"), Default: false, PreRelease: featuregate.Alpha}, | ||
| }, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.