Skip to content

Conversation

@maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Mar 14, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Introduces VPA feature gates. In order to enable a feature-gated feature, you must pass
--feature-gates=YOUR_FEATURE=true to each required component.

This PR also introduces the InPlaceOrRecreate feature gate on its own.

Which issue(s) this PR fixes:

This PR is part of the larger feature PR in #7673
Related to: #7901

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Introduces "feature gates" to the VPA.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2025
@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2025
@raywainman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2025
@adrianmoisey
Copy link
Member

/lgtm

@omerap12
Copy link
Member

/lgtm

…ediately after cutting a release branch so that new development is done against the new version
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@raywainman
Copy link
Member

/lgtm

/approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@raywainman
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxcao13, raywainman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 21, 2025
@raywainman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit b6eddb3 into kubernetes:in-place-updates Mar 21, 2025
9 of 11 checks passed
@maxcao13 maxcao13 deleted the feature-gates branch March 21, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants