VPA: Allow local dev and e2e scripts to run feature-gated features #7934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
cncf-cla: yes
Member
|
Thanks for this! Let's wait for #7932. |
k8s-ci-robot
added
the
do-not-merge/hold
maxcao13
force-pushed
the
in-place-updates-scriptchanges
branch
from
0b6f2d6 to
1092727
Compare
Member
|
Tests are broken due to #7946 |
This was referenced Mar 22, 2025
Member
|
/test all |
omerap12
reviewed
Mar 23, 2025
omerap12
approved these changes
Mar 23, 2025
Member
omerap12
left a comment
omerap12
left a comment
There was a problem hiding this comment.
Tested and seems fine to me, thanks!
/unhold
/lgtm
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Member
|
Approving so you aren't stuck waiting for me. Feel free to remove hold when you've addressed my 1 nit comment :) /approve /hold |
k8s-ci-robot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxcao13, omerap12, raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Allows you to specify an env var FEATURE_GATES which adds feature gates to all vpa components during vpa-up and e2e tests. Also allows local e2e tests to run kind with a new kind-config file which enables KEP-1287 InPlacePodVerticalScaling feature gate. Separates the admission-controller service into a separate deploy manifest. Signed-off-by: Max Cao <[email protected]>
maxcao13
force-pushed
the
in-place-updates-scriptchanges
branch
from
1092727 to
a99932a
Compare
k8s-ci-robot
removed
the
lgtm
Member
Author
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Member
|
Nit has been fixed: |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
merged commit 4486391
into
kubernetes:in-place-updates
6 of 7 checks passed
This was referenced May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
hack/vpa-up.shand/or running local e2e tests. This or does NOT add the ability to run ci e2e tests with feature gates yet. This can be subject to change.InPlacePodVerticalScalingfeature gate.Not sure if we want to include stuff in here to change the actual github ci workflow to include separate feature-gated tests (that only test
InPlaceOrRecreatefor example). We probably want to do that after the logic is actually merged into the feature branch, I'm thinking.Which issue(s) this PR fixes:
This PR is part of the larger feature PR in #7673
Depends on https://github.com/kubernetes/autoscaler/pull/7932/files
Special notes for your reviewer:
This won't work until https://github.com/kubernetes/autoscaler/pull/7932/files is merged.