Skip to content

Bump go version to 1.26 to match the main kubernetes repo#9454

Open
tetianakh wants to merge 2 commits intokubernetes:masterfrom
tetianakh:bump-go-126
Open

Bump go version to 1.26 to match the main kubernetes repo#9454
tetianakh wants to merge 2 commits intokubernetes:masterfrom
tetianakh:bump-go-126

Conversation

@tetianakh
Copy link
Copy Markdown
Contributor

@tetianakh tetianakh commented Apr 3, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bumps go version to 1.26 which is already used in the main kubernetes repo.
Also, the change fixes some bugs that were picked up by strict vet checks introduced in 1.26

Bump go version to 1.26

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 3, 2026
@tetianakh tetianakh marked this pull request as ready for review April 3, 2026 13:34
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and x13n April 3, 2026 13:34
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area area/cluster-autoscaler and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @tetianakh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-area labels Apr 3, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2026
@tetianakh tetianakh marked this pull request as draft April 3, 2026 13:38
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2026
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 3, 2026
@x13n
Copy link
Copy Markdown
Member

x13n commented Apr 3, 2026

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tetianakh, x13n
Once this PR has been reviewed and has the lgtm label, please assign jackfrancis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tetianakh tetianakh marked this pull request as ready for review April 3, 2026 14:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2026
@adrianmoisey
Copy link
Copy Markdown
Member

/cc jackfrancis

@k8s-ci-robot k8s-ci-robot requested a review from jackfrancis April 3, 2026 14:15
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2026
@tetianakh
Copy link
Copy Markdown
Contributor Author

@adrianmoisey would you be open to sponsoring my membership in the k8s org?

@adrianmoisey
Copy link
Copy Markdown
Member

@adrianmoisey would you be open to sponsoring my membership in the k8s org?

Taking a look at https://github.com/kubernetes/community/blob/main/community-membership.md#member

I see:

Members are continuously active contributors in the community

This is the first contribution I've seen, so I can't sponsor your membership, sorry.

@tetianakh
Copy link
Copy Markdown
Contributor Author

@adrianmoisey would you be open to sponsoring my membership in the k8s org?

Taking a look at https://github.com/kubernetes/community/blob/main/community-membership.md#member

I see:

Members are continuously active contributors in the community

This is the first contribution I've seen, so I can't sponsor your membership, sorry.

I have made the following contributions:

And I have 2 that are still open, not counting this one:

Until now, the automation selected reviewers and approvers from my company, so I am really stuck trying to get a second sponsor.

@adrianmoisey
Copy link
Copy Markdown
Member

The guidelines are pretty clear:

Authoring or reviewing PRs on GitHub, with at least one merged PR. NOTE: The PR(s) must demonstrate an ongoing and active commitment. A few examples include:

  • A single KEP that has taken several weeks of driving consensus
  • A larger number of smaller PRs over several weeks to months
  • A smaller number of complex or technical PRs that required working with community members to resolve an issue (e.g. regressions, bugs fixes etc)

I know it's up for interpretation, but, I don't believe that 3 merged PR and 2 open PRs satisfies: "a larger number of smaller PRs over several weeks to months"

@tetianakh
Copy link
Copy Markdown
Contributor Author

The guidelines are pretty clear:

Authoring or reviewing PRs on GitHub, with at least one merged PR. NOTE: The PR(s) must demonstrate an ongoing and active commitment. A few examples include:

  • A single KEP that has taken several weeks of driving consensus
  • A larger number of smaller PRs over several weeks to months
  • A smaller number of complex or technical PRs that required working with community members to resolve an issue (e.g. regressions, bugs fixes etc)

I know it's up for interpretation, but, I don't believe that 3 merged PR and 2 open PRs satisfies: "a larger number of smaller PRs over several weeks to months"

Ok, thank you for taking the time to consider this. I'll keep merging then!

@jackfrancis
Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@tetianakh
Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@tetianakh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-autoscaling-e2e-gci-gce-ca-test 61cf235 link false /test pull-autoscaling-e2e-gci-gce-ca-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants