Bump go version to 1.26 to match the main kubernetes repo#9454
Bump go version to 1.26 to match the main kubernetes repo#9454tetianakh wants to merge 2 commits intokubernetes:masterfrom
Conversation
|
Hi @tetianakh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tetianakh, x13n The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc jackfrancis |
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
|
New changes are detected. LGTM label has been removed. |
|
@adrianmoisey would you be open to sponsoring my membership in the k8s org? |
Taking a look at https://github.com/kubernetes/community/blob/main/community-membership.md#member I see:
This is the first contribution I've seen, so I can't sponsor your membership, sorry. |
I have made the following contributions:
And I have 2 that are still open, not counting this one:
Until now, the automation selected reviewers and approvers from my company, so I am really stuck trying to get a second sponsor. |
|
The guidelines are pretty clear:
I know it's up for interpretation, but, I don't believe that 3 merged PR and 2 open PRs satisfies: "a larger number of smaller PRs over several weeks to months" |
Ok, thank you for taking the time to consider this. I'll keep merging then! |
|
/retest |
1 similar comment
|
/retest |
|
@tetianakh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bumps go version to 1.26 which is already used in the main kubernetes repo.
Also, the change fixes some bugs that were picked up by strict
vetchecks introduced in 1.26