Skip to content

Bump go version to 1.26 to match the main kubernetes repo #9454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tetianakh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump go version to 1.26 to match the main kubernetes repo #9454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92ecdd1
Bump go version to 1.26 to match the main kubernetes repo
tetianakh Apr 3, 2026
61cf235
Update .github/workflows/ca-test.yaml
tetianakh Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ca-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0
with:
go-version: '1.25'
go-version-file: '${{ env.GOPATH}}/src/k8s.io/autoscaler/cluster-autoscaler/go.mod'
cache-dependency-path: |
${{ env.GOPATH}}/src/k8s.io/autoscaler/cluster-autoscaler/go.sum

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0
with:
go-version: '1.25'
go-version: '1.26'
cache-dependency-path: |
${{ env.GOPATH}}/src/k8s.io/autoscaler/cluster-autoscaler/go.sum
${{ env.GOPATH}}/src/k8s.io/autoscaler/vertical-pod-autoscaler/go.sum
Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM --platform=$BUILDPLATFORM golang:1.25 AS builder
FROM --platform=$BUILDPLATFORM golang:1.26 AS builder

WORKDIR /workspace

Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/apis/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module k8s.io/autoscaler/cluster-autoscaler/apis

go 1.25.0
go 1.26.0

require (
github.com/onsi/ginkgo/v2 v2.27.2
Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/cloudprovider/azure/test/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module k8s.io/autoscaler/cluster-autoscaler/cloudprovider/azure/test

go 1.24.0
go 1.26.0

toolchain go1.24.4

Expand Down
4 changes: 2 additions & 2 deletions cluster-autoscaler/core/scaledown/resource/limits.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func (lf *LimitsFinder) customResourcesTotal(autoscalingCtx *ca_context.Autoscal
if !cacheHit {
resourceTargets, err = lf.crp.GetNodeResourceTargets(autoscalingCtx, node, nodeGroup)
if err != nil {
return nil, errors.ToAutoscalerError(errors.CloudProviderError, err).AddPrefix("cannot get custom resource count for node %v when calculating cluster custom resource usage")
return nil, errors.ToAutoscalerError(errors.CloudProviderError, err).AddPrefix("cannot get custom resource count for node %v when calculating cluster custom resource usage: ", node.Name)
}
if nodeGroup != nil {
ngCache[nodeGroup.Id()] = resourceTargets
Expand Down Expand Up @@ -185,7 +185,7 @@ func (lf *LimitsFinder) DeltaForNode(autoscalingCtx *ca_context.AutoscalingConte
if cloudprovider.ContainsCustomResources(resourcesWithLimits) {
resourceTargets, err := lf.crp.GetNodeResourceTargets(autoscalingCtx, node, nodeGroup)
if err != nil {
return Delta{}, errors.ToAutoscalerError(errors.CloudProviderError, err).AddPrefix("failed to get node %v custom resources: %v", node.Name)
return Delta{}, errors.ToAutoscalerError(errors.CloudProviderError, err).AddPrefix("failed to get node %v custom resources: ", node.Name)
}
for _, resourceTarget := range resourceTargets {
resultScaleDownDelta[resourceTarget.ResourceType] = resourceTarget.ResourceCount
Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/e2e/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module k8s.io/autoscaler/cluster-autoscaler/e2e

go 1.25.3
go 1.26.0

require (
github.com/onsi/ginkgo/v2 v2.27.2
Expand Down
4 changes: 2 additions & 2 deletions cluster-autoscaler/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module k8s.io/autoscaler/cluster-autoscaler

go 1.25.0
go 1.26.0

godebug default=go1.25
godebug default=go1.26

require (
cloud.google.com/go/compute/metadata v0.9.0
Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/hack/genproto/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module k8s.io/autoscaler/cluster-autoscaler/genproto

go 1.25.3
go 1.26.0

tool (
google.golang.org/grpc/cmd/protoc-gen-go-grpc
Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/provisioningrequest/provreqclient/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (c *ProvisioningRequestClient) UpdateProvisioningRequest(pr *v1.Provisionin
if err != nil {
return pr, err
}
klog.V(4).Infof("Updated ProvisioningRequest %s/%s, status: %q,", updatedPr.Namespace, updatedPr.Name, updatedPr.Status)
klog.V(4).Infof("Updated ProvisioningRequest %s/%s, status: %+v,", updatedPr.Namespace, updatedPr.Name, updatedPr.Status)
return updatedPr, nil
}

Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/simulator/clustersnapshot/scheduling_error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (se *schedulingError) Error() string {
case NoNodesPassingPredicatesFoundError:
msg = fmt.Sprintf("couldn't find a matching Node with passing predicates")
default:
msg = fmt.Sprintf("SchedulingErrorType type %q unknown - this shouldn't happen", se.errorType)
msg = fmt.Sprintf("SchedulingErrorType type %d unknown - this shouldn't happen", se.errorType)
}

return fmt.Sprintf("can't schedule pod %s/%s: %s", se.pod.Namespace, se.pod.Name, msg)
Expand Down