aws: skip node S3 permissions when kops-controller serves node config#18251
Conversation
Nodes only needed S3 read access to fetch their nodeup config from the state store. When kops-controller is used for node config, nodes obtain it from kops-controller instead, so the S3 grants are unnecessary. Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
k8s-ci-robot
added
size/XL
|
/override pull-kops-e2e-azure-cni-calico |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-azure-cni-calico DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/test all |
|
/override pull-kops-e2e-azure-cni-cilium |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-azure-cni-cilium DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…8251-upstream-release-1.35 Automated cherry pick of #18251: aws: skip node S3 permissions when kops-controller serves node config
…8251-upstream-release-1.34 Automated cherry pick of #18251: aws: skip node S3 permissions when kops-controller serves node config
3 participants
Nodes only needed S3 read access to fetch their nodeup config from the state store. When kops-controller is used for node config, nodes obtain it from kops-controller instead, so the S3 grants are unnecessary.
/cc @rifelpet @ameukam