Automated cherry pick of #18298: dns-controller: make priorityClassName configurable#18300
Merged
k8s-ci-robot merged 1 commit intoMay 10, 2026
Conversation
The pod's priorityClassName was hardcoded to system-cluster-critical. Expose it as spec.externalDNS.priorityClassName so it can be overridden or dropped (set to ""). This lets the upgrade e2e presubmits drop the priorityClassName so `kops validate cluster` ignores the dns-controller pod while the new image hasn't side-loaded. Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
k8s-ci-robot
added
cncf-cla: yes
Member
Author
k8s-ci-robot
added
the
approved
upodroid
approved these changes
May 10, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #18298 on release-1.34.
#18298: dns-controller: make priorityClassName configurable
For details on the cherry pick process, see the cherry pick requests page.
What type of PR is this?