test: optimize mysql test#22546
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
kvm2 driver with docker runtime DetailsTimes for minikube start: 37.0s 39.5s 38.7s 37.6s 36.2s Times for minikube ingress: 15.8s 16.4s 14.8s 14.8s 15.3s docker driver with docker runtime DetailsTimes for minikube start: 22.4s 21.5s 18.7s 19.5s 22.2s Times for minikube ingress: 12.7s 10.7s 10.7s 10.7s 10.7s docker driver with containerd runtime DetailsTimes for minikube ingress: 23.2s 23.2s 24.2s 24.2s 23.2s Times for minikube start: 16.5s 19.8s 16.6s 19.8s 20.2s |
|
@medyagh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Pull request overview
This PR optimizes the MySQL integration test to reduce resource consumption and enables it to run on ARM64 platforms. The optimization includes setting MySQL configuration arguments to reduce CPU and memory usage, lowering resource requests and limits, and removing the ARM64 platform skip that was previously in place.
Changes:
- Added MySQL optimization arguments (performance-schema=OFF, reduced buffer pool, disabled binary logging, limited connections, skip-name-resolve) to reduce resource usage
- Reduced MySQL pod resource requests from 512Mi/600m to 256Mi/100m and limits from 700Mi/700m to 384Mi/500m
- Removed ARM64 platform skip in the validateMySQL test function to enable testing on ARM64 platforms
- Changed Azure CLI cleanup verification step from using azure/cli@v2 action to a direct run command (unrelated to main PR purpose)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/integration/testdata/mysql.yaml | Added MySQL optimization arguments and reduced resource requests/limits to minimize CPU and memory usage |
| test/integration/functional_test.go | Removed ARM64 platform skip to enable MySQL testing on ARM64 architectures |
| .github/workflows/functional_extra.yml | Changed cleanup verification from azure/cli action to direct run command (appears unrelated to PR focus) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if: always() && steps.azlogin.outcome == 'success' | ||
| uses: azure/cli@v2 | ||
| with: | ||
| echo "Verifying cleanup..." | ||
| az resource list --resource-group "${{ env.MINIKUBE_AZ_RESOURCE_GROUP }}" --query "[].{Name:name, Type:type, Created:createdTime}" --output table | ||
| run: | | ||
| echo "Verifying cleanup..." | ||
| az resource list --resource-group "${{ env.MINIKUBE_AZ_RESOURCE_GROUP }}" --query "[].{Name:name, Type:type, Created:createdTime}" --output table |
There was a problem hiding this comment.
This workflow change appears unrelated to the PR description, which focuses on optimizing MySQL tests and adding ARM64 support. The change from using the azure/cli@v2 action to a direct run command should be in a separate PR or explained in the PR description if intentional.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages: DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Uh oh!
There was an error while loading. Please reload this page.