Skip to content

test: optimize mysql test#22546

Merged
medyagh merged 3 commits intokubernetes:masterfrom
medyagh:mysql_test
Jan 25, 2026
Merged

test: optimize mysql test#22546
medyagh merged 3 commits intokubernetes:masterfrom
medyagh:mysql_test

Conversation

@medyagh
Copy link
Copy Markdown
Member

@medyagh medyagh commented Jan 25, 2026

  • reduce cpu/memory usage by setting the optimization args
  • also run test on arm64

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from prezha January 25, 2026 11:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2026
@medyagh medyagh added the ok-to-extra-test test extra environments label Jan 25, 2026
@medyagh
Copy link
Copy Markdown
Member Author

medyagh commented Jan 25, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 25, 2026
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22546 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 37.8s    │ 39.2s                  │
│ enable ingress │ 15.4s    │ 15.9s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 37.0s 39.5s 38.7s 37.6s 36.2s
Times for minikube (PR 22546) start: 36.0s 39.9s 39.8s 39.7s 40.7s

Times for minikube ingress: 15.8s 16.4s 14.8s 14.8s 15.3s
Times for minikube (PR 22546) ingress: 15.8s 15.8s 15.3s 16.3s 16.3s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22546 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 20.9s    │ 21.4s                  │
│ enable ingress │ 11.1s    │ 10.7s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 22.4s 21.5s 18.7s 19.5s 22.2s
Times for minikube (PR 22546) start: 18.8s 22.5s 21.8s 21.9s 21.8s

Times for minikube ingress: 12.7s 10.7s 10.7s 10.7s 10.7s
Times for minikube (PR 22546) ingress: 10.7s 10.7s 10.7s 10.7s 10.7s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22546 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 18.6s    │ 19.3s                  │
│ enable ingress │ 23.6s    │ 23.2s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube ingress: 23.2s 23.2s 24.2s 24.2s 23.2s
Times for minikube (PR 22546) ingress: 23.2s 23.2s 23.2s 23.2s 23.1s

Times for minikube start: 16.5s 19.8s 16.6s 19.8s 20.2s
Times for minikube (PR 22546) start: 16.5s 20.5s 19.8s 19.6s 20.0s

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 25, 2026

@medyagh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-none-containerd-linux-x86 3f794c1 link false /test integration-none-containerd-linux-x86
integration-docker-containerd-linux-x86 3f794c1 link true /test integration-docker-containerd-linux-x86
integration-docker-crio-linux-x86 3f794c1 link false /test integration-docker-crio-linux-x86
integration-kvm-crio-linux-x86 3f794c1 link false /test integration-kvm-crio-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the MySQL integration test to reduce resource consumption and enables it to run on ARM64 platforms. The optimization includes setting MySQL configuration arguments to reduce CPU and memory usage, lowering resource requests and limits, and removing the ARM64 platform skip that was previously in place.

Changes:

  • Added MySQL optimization arguments (performance-schema=OFF, reduced buffer pool, disabled binary logging, limited connections, skip-name-resolve) to reduce resource usage
  • Reduced MySQL pod resource requests from 512Mi/600m to 256Mi/100m and limits from 700Mi/700m to 384Mi/500m
  • Removed ARM64 platform skip in the validateMySQL test function to enable testing on ARM64 platforms
  • Changed Azure CLI cleanup verification step from using azure/cli@v2 action to a direct run command (unrelated to main PR purpose)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
test/integration/testdata/mysql.yaml Added MySQL optimization arguments and reduced resource requests/limits to minimize CPU and memory usage
test/integration/functional_test.go Removed ARM64 platform skip to enable MySQL testing on ARM64 architectures
.github/workflows/functional_extra.yml Changed cleanup verification from azure/cli action to direct run command (appears unrelated to PR focus)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/integration/testdata/mysql.yaml Outdated
Comment thread test/integration/testdata/mysql.yaml Outdated
Comment on lines 186 to +189
if: always() && steps.azlogin.outcome == 'success'
uses: azure/cli@v2
with:
echo "Verifying cleanup..."
az resource list --resource-group "${{ env.MINIKUBE_AZ_RESOURCE_GROUP }}" --query "[].{Name:name, Type:type, Created:createdTime}" --output table
run: |
echo "Verifying cleanup..."
az resource list --resource-group "${{ env.MINIKUBE_AZ_RESOURCE_GROUP }}" --query "[].{Name:name, Type:type, Created:createdTime}" --output table
Copy link

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow change appears unrelated to the PR description, which focuses on optimizing MySQL tests and adding ARM64 support. The change from using the azure/cli@v2 action to a direct run command should be in a separate PR or explained in the PR description if intentional.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 25, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • c68372e Apply suggestion from @Copilot
  • e9e7741 Apply suggestion from @Copilot
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@medyagh medyagh merged commit 87fea79 into kubernetes:master Jan 25, 2026
9 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. ok-to-extra-test test extra environments ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants