Skip to content

test: optimize mysql test #22546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
medyagh merged 3 commits into from
Jan 25, 2026
Merged

test: optimize mysql test #22546

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f794c1
optimize mysql test
medyagh Jan 25, 2026
c68372e
Apply suggestion from @Copilot
medyagh Jan 25, 2026
e9e7741
Apply suggestion from @Copilot
medyagh Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/functional_extra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ jobs:

- name: Verify Cleanup
if: always() && steps.azlogin.outcome == 'success'
uses: azure/cli@v2
with:
echo "Verifying cleanup..."
az resource list --resource-group "${{ env.MINIKUBE_AZ_RESOURCE_GROUP }}" --query "[].{Name:name, Type:type, Created:createdTime}" --output table
run: |
echo "Verifying cleanup..."
az resource list --resource-group "${{ env.MINIKUBE_AZ_RESOURCE_GROUP }}" --query "[].{Name:name, Type:type, Created:createdTime}" --output table
Comment on lines 186 to +189
Copy link

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow change appears unrelated to the PR description, which focuses on optimizing MySQL tests and adding ARM64 support. The change from using the azure/cli@v2 action to a direct run command should be in a separate PR or explained in the PR description if intentional.

Copilot uses AI. Check for mistakes.
5 changes: 0 additions & 5 deletions test/integration/functional_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1795,11 +1795,6 @@ func validateCpCmd(ctx context.Context, t *testing.T, profile string) {

// validateMySQL validates a minimalist MySQL deployment
func validateMySQL(ctx context.Context, t *testing.T, profile string) {
// docs(skip): Skips for ARM64 architecture since it's not supported by MySQL
if arm64Platform() {
t.Skip("arm64 is not supported by mysql. Skip the test. See https://github.com/kubernetes/minikube/issues/10144")
}

defer PostMortemLogs(t, profile)

// docs: Run `kubectl replace --force -f testdata/mysql/yaml`
Expand Down
23 changes: 17 additions & 6 deletions test/integration/testdata/mysql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,28 @@ spec:
containers:
- image: public.ecr.aws/docker/library/mysql:8.4
name: mysql
args:
# 1. Existing optimization
- "--performance-schema=OFF"
Comment thread
medyagh marked this conversation as resolved.
Outdated
# 2. CRITICAL: Reduce buffer pool to fit in 384Mi limit
# 64M is safe for dev; allows room for OS + connections
- "--innodb-buffer-pool-size=64M"
# 3. Disable binary logging (saves I/O and CPU)
- "--disable-log-bin"
# 4. Limit connections to save per-thread memory
- "--max-connections=50"
# 5. Skip DNS lookups (saves a tiny bit of CPU/latency on connect)
- "--skip-name-resolve"
resources:
requests:
memory: "512Mi"
cpu: "600m"
memory: "256Mi"
cpu: "100m"
limits:
memory: "700Mi"
cpu: "700m"
memory: "384Mi"
Comment thread
medyagh marked this conversation as resolved.
Outdated
cpu: "500m"
env:
# Use secret in real usage
- name: MYSQL_ROOT_PASSWORD
value: password
ports:
- containerPort: 3306
name: mysql
name: mysql
Loading