Skip to content

docs: clarify generated image build test docs#22813

Open
iacker wants to merge 1 commit intokubernetes:masterfrom
iacker:docs/testdocs-imagebuild-detail
Open

docs: clarify generated image build test docs#22813
iacker wants to merge 1 commit intokubernetes:masterfrom
iacker:docs/testdocs-imagebuild-detail

Conversation

@iacker
Copy link
Copy Markdown

@iacker iacker commented Apr 7, 2026

Summary

  • make the generated integration test docs for validateImageCommands describe the actual image-build path in more detail
  • mention the Dockerfile fixture, copied content.txt, on-demand buildkitd startup, and runtime image verification
  • regenerate site/content/en/docs/contrib/tests.en.md

Testing

  • PATH="/opt/homebrew/bin:$PATH" go test ./cmd/minikube/cmd -run TestGenerateTestDocs
  • PATH="/opt/homebrew/bin:$PATH" make generate-docs

Closes #11571

Signed-off-by: Billard <82095453+iacker@users.noreply.github.com>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iacker
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @iacker. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 7, 2026
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add detailed info about what each integration test is doing to the site

3 participants