Skip to content

docs: clarify generated image build test docs #22813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iacker wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

docs: clarify generated image build test docs #22813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion site/content/en/docs/contrib/tests.en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ Steps:
runs tests on all the `minikube image` commands, ex. `minikube image load`, `minikube image list`, etc.

Steps:
- Make sure image building works by `minikube image build`
- Build an image with `minikube image build` using `test/integration/testdata/build/Dockerfile`
- Add `content.txt` from the build context into a `gcr.io/k8s-minikube/busybox` image and tag it as `localhost/my-image:<profile>`
- Start `buildkitd` on demand inside minikube only when the build runs, then verify the new image exists in the cluster runtime
- Make sure image loading from Docker daemon works by `minikube image load --daemon`
- Try to load image already loaded and make sure `minikube image load --daemon` works
- Make sure a new updated tag works by `minikube image load --daemon`
Expand Down
4 changes: 3 additions & 1 deletion test/integration/functional_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,9 @@ func validateImageCommands(ctx context.Context, t *testing.T, profile string) {
runImageList(ctx, t, profile, "ImageListJson", "json", "[\"%s")
runImageList(ctx, t, profile, "ImageListYaml", "yaml", "- %s")

// docs: Make sure image building works by `minikube image build`
// docs: Build an image with `minikube image build` using `test/integration/testdata/build/Dockerfile`
// docs: Add `content.txt` from the build context into a `gcr.io/k8s-minikube/busybox` image and tag it as `localhost/my-image:<profile>`
// docs: Start `buildkitd` on demand inside minikube only when the build runs, then verify the new image exists in the cluster runtime
t.Run("ImageBuild", func(t *testing.T) {
MaybeParallel(t)

Expand Down