config: add all image-pushing jobs to a wg-k8s-infra-gcb testgrid dashboard #22898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Currently it only reformats according to hardcoded settings
In preparation for mass-editing jobs with ruamel.yaml, which will enforce _some_ kind of formatting changes re: indentation, move all jobs to whichever format causes the least amount of delta. This will allow the mass-edit commit to be isolated just to job changes vs. formatting changes. There are two classes of changes squashed into this commit. First, two staging repos that generate their jobs from a shell script, so update the formatting in the script, and regenerate the jobs: - k8s-staging-e2e-test-images - k8s-staging-sig-storage Second, format everything else using experiment/edit-prowjobs.py. Since most people copy-pasted from the same example, this changed: - k8s-staging-cluster-api - k8s-staging-kubetest2 - k8s-staging-releng
Split checks that are specific to whether a job is a valid image-pushing job out of whether it is authorized to run on k8s-infra-prow-build-trusted Add a new check (that will fail until following commits) that enforces all image-pushing jobs must be on the new wg-k8s-infra-gcb testgrid dashboard
spiffxp
force-pushed
the
wg-k8s-infra-gcb-dashboard
branch
from
968873b
to
c7359b1
Compare
also addressed pylint errors and warnings
This involves three sets of changes: - adding the wg-k8s-infra-gcb dashboard to config/testgrids - using edit-prowjobs.py to mass-edit all but one image-pushing job - manually edit post-security-profiles-operator-push-image in k8s-staging-seccomp-operator.yaml to add a testgrid-dashboards annotation The last change exposes the fact that there is no one-true-yaml that defines both prowjobs and all of their testgrid dashboards. The job has another testgrid dashboard tab defined in a testgrid config. It can't be moved to the prowjob config as-is, because it has a custom base_options setting for width, and acontext-free name that wouldn't make sense on the wg-k8s-infra-gcb dashboard. Neither base_options nor different tab names are currently supported by the prowjob-annotation-based testgrid configurator.
spiffxp
force-pushed
the
wg-k8s-infra-gcb-dashboard
branch
from
c7359b1
to
d936390
Compare
spiffxp
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
cpanato
approved these changes
Jul 15, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd recommend reviewing by commit rather than everything at once, see commit messages for details.
This provides a single location to check on the status of image pushing across the entire kubernetes project, to help track #20652