Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add all image-pushing jobs to a wg-k8s-infra-gcb testgrid dashboard #22898

Merged
merged 5 commits into from
Jul 15, 2021
Merged

config: add all image-pushing jobs to a wg-k8s-infra-gcb testgrid dashboard #22898

merged 5 commits into from
Jul 15, 2021

Commits on Jul 15, 2021

  1. experiment: add edit-prowjobs.py 

    Currently it only reformats according to hardcoded settings
    @spiffxp
    spiffxp committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    b36ef24 View commit details
    Browse the repository at this point in the history

  2. config/jobs/image-pushing: converge job formatting 

    In preparation for mass-editing jobs with ruamel.yaml, which will
enforce _some_ kind of formatting changes re: indentation, move all jobs
to whichever format causes the least amount of delta. This will allow
the mass-edit commit to be isolated just to job changes vs. formatting
changes.

There are two classes of changes squashed into this commit.

First, two staging repos that generate their jobs from a shell script,
so update the formatting in the script, and regenerate the jobs:
- k8s-staging-e2e-test-images
- k8s-staging-sig-storage

Second, format everything else using experiment/edit-prowjobs.py. Since
most people copy-pasted from the same example, this changed:
- k8s-staging-cluster-api
- k8s-staging-kubetest2
- k8s-staging-releng
    @spiffxp
    spiffxp committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    ae84c33 View commit details
    Browse the repository at this point in the history

  3. config/tests: add image-pushing jobs test 

    Split checks that are specific to whether a job is a valid image-pushing
job out of whether it is authorized to run on
k8s-infra-prow-build-trusted

Add a new check (that will fail until following commits) that enforces all
image-pushing jobs must be on the new wg-k8s-infra-gcb testgrid
dashboard
    @spiffxp
    spiffxp committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    b24abf4 View commit details
    Browse the repository at this point in the history

  4. experiment: edit-prowjobs adds wg-k8s-infra-gcb to jobs 

    also addressed pylint errors and warnings
    @spiffxp
    spiffxp committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    fea01cd View commit details
    Browse the repository at this point in the history

  5. config: add wg-k8s-infra-gcb dashboard to all image-pushing jobs 

    This involves three sets of changes:
- adding the wg-k8s-infra-gcb dashboard to config/testgrids
- using edit-prowjobs.py to mass-edit all but one image-pushing job
- manually edit post-security-profiles-operator-push-image in
  k8s-staging-seccomp-operator.yaml to add a testgrid-dashboards
  annotation

The last change exposes the fact that there is no one-true-yaml that
defines both prowjobs and all of their testgrid dashboards. The job
has another testgrid dashboard tab defined in a testgrid config. It
can't be moved to the prowjob config as-is, because it has a custom
base_options setting for width, and acontext-free name that wouldn't
make sense on the wg-k8s-infra-gcb dashboard. Neither base_options
nor different tab names are currently supported by the
prowjob-annotation-based testgrid configurator.
    @spiffxp
    spiffxp committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    d936390 View commit details
    Browse the repository at this point in the history